commit 06edfa575966f1f72cde77a7e7cd02324f9c9541
author Rob Mohr <mohrr@google.com> Tue Mar 12 19:29:53 2024 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Mar 12 19:29:53 2024 +0000
tree b2312a588b7619bcf888d57556da14826c325bf3
parent ae678a69f6ab54a34eae3311563ebd485038711d

cq_deps: Drop statuses arg

This has been unused for a long time now. It was only ever used by
rollers, and rollers no longer use cq_deps.

Bug: b/328489817
Change-Id: I982abdf50cf7e9cc537e52734de33feab213a438
Reviewed-on: https://pigweed-review.googlesource.com/c/infra/recipes/+/196171
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
Reviewed-by: Ted Pudlik <tpudlik@google.com>

recipe_modules/cq_deps/api.py

diff --git a/recipe_modules/cq_deps/api.py b/recipe_modules/cq_deps/api.py
index b76cc9a..dcda783 100644
--- a/recipe_modules/cq_deps/api.py
+++ b/recipe_modules/cq_deps/api.py
@@ -108,7 +108,6 @@
         self,
         gerrit_name: str,
         number: int | str,
-        statuses: Sequence[ChangeState] = ('NEW',),
     ) -> tuple[Sequence[Change], Sequence[Change]]:
         """Recursively resolve dependencies of a CL.
 
@@ -118,7 +117,6 @@
             gerrit_name (str): Name of Gerrit host of initial change.
             number (int|str): Gerrit number or git commit hash of initial
                 change.
-            statuses (seq(str)): CL statuses to accept.
 
         Returns a tuple of resolved Change objects (excluding the given change)
         and unresolved Change objects (which are not completely populated).
@@ -157,7 +155,7 @@
                             if not details:
                                 unresolved.append(dep)
                                 continue
-                            if details['status'] not in statuses:
+                            if details['status'] != 'NEW':
                                 continue
 
                             if dep.name not in seen:

recipe_modules/cq_deps/tests/full.py

diff --git a/recipe_modules/cq_deps/tests/full.py b/recipe_modules/cq_deps/tests/full.py
index 6251426..53072f8 100644
--- a/recipe_modules/cq_deps/tests/full.py
+++ b/recipe_modules/cq_deps/tests/full.py
@@ -24,16 +24,11 @@
 
 PROPERTIES = {
     'revision': Property(kind=str, default=None),
-    'statuses': Property(kind=List(str), default=('NEW',)),
 }
 
 
-def RunSteps(api, revision, statuses):
-    deps, errors = api.cq_deps.resolve(
-        'pigweed',
-        revision or 1,
-        statuses=statuses,
-    )
+def RunSteps(api, revision):
+    deps, errors = api.cq_deps.resolve('pigweed', revision or 1)
 
     with api.step.nest('final deps'):
         for dep in deps: