Reland "pw_presubmit: Move most logic to a module"

This is a reland of 618497de3d75d46f0eb52aac984cca10c41c3349

Differences from the original CL:
* pwrev/67821 has landed and this CL moves it to the new module
* pwirev/17540 has landed

Original change's description:
> pw_presubmit: Move most logic to a module
>
> Move most logic from the pw_presubmit recipe to a module. For now, leave
> the signing and upload logic in the recipe.
>
> Bug: 523
> Change-Id: I413cb9e757c98d09a9896d4466012f825e80c0f1
> Reviewed-on: https://pigweed-review.googlesource.com/c/infra/recipes/+/67229
> Commit-Queue: Rob Mohr <mohrr@google.com>
> Reviewed-by: Oliver Newman <olivernewman@google.com>

Bug: 523
Change-Id: I455d49b25412f70826bda94600ad532ff1f27a37
Reviewed-on: https://pigweed-review.googlesource.com/c/infra/recipes/+/67820
Reviewed-by: Ted Pudlik <tpudlik@google.com>
Commit-Queue: Rob Mohr <mohrr@google.com>
18 files changed
tree: 60e211bdb5ff8cf7c516e43197c6e2c227d7bc57
  1. infra/
  2. recipe_modules/
  3. recipes/
  4. scripts/
  5. .gitignore
  6. .style.yapf
  7. cipd.ensure
  8. OWNERS
  9. presubmit.sh
  10. pyproject.toml
  11. README.md
  12. recipes.py
README.md

Pigweed Recipes

This repository contains recipes for Pigweed.

A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Pigweed and downstream projects using Pigweed in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Pigweed in your local environment.

See go/pigweed-recipe-docs for complete documentation and a guide for getting started with writing recipes.

Getting the Code

The recommended way to get the source code is with git.

git clone https://pigweed.googlesource.com/infra/recipes

In most cases you will need a Chromium depot_tools checkout in your PATH as well.

git clone https://chromium.googlesource.com/chromium/tools/depot_tools ~/depot_tools
echo 'export PATH="$PATH:$HOME/depot_tools"' >> ~/.bashrc

Running Tests

./presubmit.sh runs three different sets of tests:

  • Recipe expectation tests (./recipes.py test train)
  • Formatting (./black --diff --check .)
  • Dependencies (.recipe_deps/fuchsia/scripts/cleanup_deps.py --check)

The formatting check will tell you what‘s wrong but not fix it. For that you need to run ./black .. Similarly, the dependencies check will tell you what’s wrong but you'll need to edit the files to fix issues.

If not using ./presubmit.sh you'll need to run ./scripts/ensure_black.sh before ./black is present.