commit 46cb6e91efd94bee53628f4c1600fdbd9bcc2ea7
author Rob Mohr <mohrr@google.com> Fri Dec 20 08:52:00 2024 -0800
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Dec 20 08:52:00 2024 -0800
tree 881807f17e20b858a1a3d59656f9e8bbba165798
parent 646cc73808fa1f9d5be4d2e6b9f5567020186cad

roll_commenter: Add debug steps

Bug: b/369718402
Change-Id: Iecd6a3dce22e6c71064b4791af28037c8dc2879c
Reviewed-on: https://pigweed-review.googlesource.com/c/infra/recipes/+/255962
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Dave Roth <davidroth@google.com>
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>

recipes/roll_commenter.expected/no_forward_progress.json

diff --git a/recipes/roll_commenter.expected/no_forward_progress.json b/recipes/roll_commenter.expected/no_forward_progress.json
index 4949f5c..1a519d4 100644
--- a/recipes/roll_commenter.expected/no_forward_progress.json
+++ b/recipes/roll_commenter.expected/no_forward_progress.json
@@ -541,6 +541,13 @@
   },
   {
     "cmd": [],
+    "name": "potentially stuck.trailing failing rollers.project/roll/foo-roller",
+    "~followup_annotations": [
+      "@@@STEP_NEST_LEVEL@2@@@"
+    ]
+  },
+  {
+    "cmd": [],
     "name": "c000011",
     "~followup_annotations": [
       "@@@STEP_SUMMARY_TEXT@successfully warned@@@",

recipes/roll_commenter.expected/no_forward_progress_dry_run_already_warned.json

diff --git a/recipes/roll_commenter.expected/no_forward_progress_dry_run_already_warned.json b/recipes/roll_commenter.expected/no_forward_progress_dry_run_already_warned.json
index 3fface1..d50b288 100644
--- a/recipes/roll_commenter.expected/no_forward_progress_dry_run_already_warned.json
+++ b/recipes/roll_commenter.expected/no_forward_progress_dry_run_already_warned.json
@@ -541,6 +541,13 @@
   },
   {
     "cmd": [],
+    "name": "potentially stuck.trailing failing rollers.project/roll/foo-roller",
+    "~followup_annotations": [
+      "@@@STEP_NEST_LEVEL@2@@@"
+    ]
+  },
+  {
+    "cmd": [],
     "name": "c000011",
     "~followup_annotations": [
       "@@@STEP_SUMMARY_TEXT@dry run, not warning@@@",

recipes/roll_commenter.py

diff --git a/recipes/roll_commenter.py b/recipes/roll_commenter.py
index b6254a0..3b6a7aa 100644
--- a/recipes/roll_commenter.py
+++ b/recipes/roll_commenter.py
@@ -361,6 +361,7 @@
                 if api.builder_status.is_passing(builder_status[builder_key]):
                     continue
                 trailing_failing_rollers.append(builder_key)
+                api.step.empty(builder_key)
 
     def link(build: build_pb.Build, suppress: bool | None = None) -> str:
         if suppress is None:
@@ -372,7 +373,7 @@
         return f'[{roller}]({url})'
 
     if not trailing_failing_rollers:
-        api.step.empty('no trailing failing rollers')  # pragma: no cover
+        api.step.empty('no trailing failing rollers')
         summary = [f'{behind}, but rollers are passing, waiting on:', '']
         for roller in trailing_rollers:
             build = builder_status[roller].builds[0]