Google Git
Sign in
pigweed / infra / recipes / 49cd63ffb11bdbca9f88078d7f052900ed3c5cca
commit49cd63ffb11bdbca9f88078d7f052900ed3c5cca[log] [tgz]
authorRob Mohr <mohrr@google.com>Thu Oct 21 12:58:02 2021 -0700
committerCQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Oct 21 20:31:15 2021 +0000
tree7079b43eff88c46fbec1ddf73d8d19fb0518aad5
parentf1a7a35f4319a21af0024037a1e032f73a5de7eb [diff]
build, pw_presubmit: Move build log saving code

Move the code that saves build logs from the pw_presubmit recipe to the
build module. Also, log the longest build steps as separate steps--the
old Milo UI (still used for led jobs) shows these as expected but the
new Milo UI shows a multi-line step_summary_text on one line.

Change-Id: Ia85810016cb31560d527acb2b43d05a4d856f16e
Reviewed-on: https://pigweed-review.googlesource.com/c/infra/recipes/+/66320
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
Reviewed-by: Ted Pudlik <tpudlik@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
10 files changed
tree: 7079b43eff88c46fbec1ddf73d8d19fb0518aad5
  1. infra/
  2. recipe_modules/
  3. recipes/
  4. scripts/
  5. black ⇨ .cipd/black
  6. .gitignore
  7. .style.yapf
  8. cipd.ensure
  9. OWNERS
  10. presubmit.sh
  11. pyproject.toml
  12. README.md
  13. recipes.py
README.md

Pigweed Recipes

This repository contains recipes for Pigweed.

A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Pigweed and downstream projects using Pigweed in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Pigweed in your local environment.

See go/pigweed-recipe-docs for complete documentation and a guide for getting started with writing recipes.

Getting the Code

The recommended way to get the source code is with git.

git clone https://pigweed.googlesource.com/infra/recipes

In most cases you will need a Chromium depot_tools checkout in your PATH as well.

git clone https://chromium.googlesource.com/chromium/tools/depot_tools ~/depot_tools
echo 'export PATH="$PATH:$HOME/depot_tools"' >> ~/.bashrc

Running Tests

./presubmit.sh runs three different sets of tests:

  • Recipe expectation tests (./recipes.py test train)
  • Formatting (./black --diff --check .)
  • Dependencies (.recipe_deps/fuchsia/scripts/cleanup_deps.py --check)

The formatting check will tell you what‘s wrong but not fix it. For that you need to run ./black .. Similarly, the dependencies check will tell you what’s wrong but you'll need to edit the files to fix issues.

If not using ./presubmit.sh you'll need to run ./scripts/ensure_black.sh before ./black is present.