Google Git
Sign in
pigweed / infra / recipes / 4fe9671cd0d8eece20468ff4d87c96e68f93e1eb
commit4fe9671cd0d8eece20468ff4d87c96e68f93e1eb[log] [tgz]
authorRob Mohr <mohrr@google.com>Thu Jul 25 22:29:15 2024 +0000
committerCQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jul 25 22:29:15 2024 +0000
tree5d6ac853f99196609503b2a33d1bc0f692c7b528
parentd65e8c97c10d5906a362cbcdb5c502d86da7b8cf [diff]
bazel: Fix trimming behavior

Previously a block like this:

    irrelevant line 1

    irrelevant line 2

    block we care about

    irrelevant line 3

    irrelevant line 4

Would be trimmed to this:

    irrelevant line 2

    block we care about

This was because it looked for the first blank line preceding the part
we care about. Now it looks for the last such blank line.

Bug: b/355424795
Change-Id: If0e43d2cdc8fc49f965d1b6cd73807585d27ceb2
Reviewed-on: https://pigweed-review.googlesource.com/c/infra/recipes/+/226067
Reviewed-by: Ted Pudlik <tpudlik@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
3 files changed
tree: 5d6ac853f99196609503b2a33d1bc0f692c7b528
  1. infra/
  2. recipe_modules/
  3. recipes/
  4. scripts/
  5. black ⇨ .cipd/black
  6. .editorconfig
  7. .gitignore
  8. .style.yapf
  9. AUTHORS
  10. cipd.ensure
  11. LICENSE
  12. OWNERS
  13. presubmit.sh
  14. pyproject.toml
  15. README.md
  16. recipes.py
README.md

Pigweed Recipes

This repository contains recipes for Pigweed.

A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Pigweed and downstream projects using Pigweed in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Pigweed in your local environment.

See go/pigweed-recipe-docs for complete documentation and a guide for getting started with writing recipes.

Getting the Code

The recommended way to get the source code is with git.

git clone https://pigweed.googlesource.com/infra/recipes

In most cases you will need a Chromium depot_tools checkout in your PATH as well.

git clone https://chromium.googlesource.com/chromium/tools/depot_tools ~/depot_tools
echo 'export PATH="$PATH:$HOME/depot_tools"' >> ~/.bashrc

Running Tests

./presubmit.sh runs three different sets of tests:

  • Recipe expectation tests (./recipes.py test train)
  • Formatting (./black --diff --check .)
  • Dependencies (.recipe_deps/fuchsia/scripts/cleanup_deps.py --check)

The formatting check will tell you what‘s wrong but not fix it. For that you need to run ./black .. Similarly, the dependencies check will tell you what’s wrong but you'll need to edit the files to fix issues.

If not using ./presubmit.sh you'll need to run ./scripts/ensure_black.sh before ./black is present.