| commit | 52bd0398d39abdc3c05b91c8f1219673410bc55f | [log] [tgz] |
|---|---|---|
| author | Rob Mohr <mohrr@google.com> | Mon Mar 25 20:43:10 2024 +0000 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 25 20:43:10 2024 +0000 |
| tree | 05b372c4892ec8e1d5cbdb828cb6e2ff9eed317b | |
| parent | 6df04925132c561b5abf14d007066a50aad5b43e [diff] |
pw_presubmit: Don't start new steps if out of time Don't start new steps if there likely won't be enough time for them to complete. Occasionally a presubmit step hangs, is killed with a minute or so left before the builder timeout, and then a bunch of steps trigger in quick succession, each being killed a few seconds later because they weren't given enough time to complete. Sometimes, one is killed by buildbucket and the build is marked as an infra failure. Change that so the build bails when there's not enough time left to do anything. It may still extract logs, but it won't start new pw_presubmit steps. Change-Id: If6ca27b1c457b5180697195994d63432829d5997 Reviewed-on: https://pigweed-review.googlesource.com/c/infra/recipes/+/199610 Commit-Queue: Rob Mohr <mohrr@google.com> Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Ted Pudlik <tpudlik@google.com>
This repository contains recipes for Pigweed.
A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Pigweed and downstream projects using Pigweed in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Pigweed in your local environment.
See go/pigweed-recipe-docs for complete documentation and a guide for getting started with writing recipes.
The recommended way to get the source code is with git.
git clone https://pigweed.googlesource.com/infra/recipes
In most cases you will need a Chromium depot_tools checkout in your PATH as well.
git clone https://chromium.googlesource.com/chromium/tools/depot_tools ~/depot_tools echo 'export PATH="$PATH:$HOME/depot_tools"' >> ~/.bashrc
./presubmit.sh runs three different sets of tests:
./recipes.py test train)./black --diff --check .).recipe_deps/fuchsia/scripts/cleanup_deps.py --check)The formatting check will tell you what‘s wrong but not fix it. For that you need to run ./black .. Similarly, the dependencies check will tell you what’s wrong but you'll need to edit the files to fix issues.
If not using ./presubmit.sh you'll need to run ./scripts/ensure_black.sh before ./black is present.