| commit | 7813046ba1f8a33860d2f86a18055bfc6ef04432 | [log] [tgz] |
|---|---|---|
| author | Rob Mohr <mohrr@google.com> | Mon Nov 08 18:04:09 2021 +0000 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Nov 08 18:10:24 2021 +0000 |
| tree | 9ce2f1a02f08d5b61f56ea6804c2ec3ef6937a33 | |
| parent | 618497de3d75d46f0eb52aac984cca10c41c3349 [diff] |
Revert "pw_presubmit: Move most logic to a module" This reverts commit 618497de3d75d46f0eb52aac984cca10c41c3349. Reason for revert: not running steps in pw_presubmit recipes Original change's description: > pw_presubmit: Move most logic to a module > > Move most logic from the pw_presubmit recipe to a module. For now, leave > the signing and upload logic in the recipe. > > Bug: 523 > Change-Id: I413cb9e757c98d09a9896d4466012f825e80c0f1 > Reviewed-on: https://pigweed-review.googlesource.com/c/infra/recipes/+/67229 > Commit-Queue: Rob Mohr <mohrr@google.com> > Reviewed-by: Oliver Newman <olivernewman@google.com> TBR=mohrr@google.com,olivernewman@google.com,pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com,tpudlik@google.com Change-Id: I0ff688a995bb3c6afcf0a87f943df7eca0b680f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 523 Reviewed-on: https://pigweed-review.googlesource.com/c/infra/recipes/+/67801 Reviewed-by: Armando Montanez <amontanez@google.com> Commit-Queue: Rob Mohr <mohrr@google.com>
This repository contains recipes for Pigweed.
A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Pigweed and downstream projects using Pigweed in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Pigweed in your local environment.
See go/pigweed-recipe-docs for complete documentation and a guide for getting started with writing recipes.
The recommended way to get the source code is with git.
git clone https://pigweed.googlesource.com/infra/recipes
In most cases you will need a Chromium depot_tools checkout in your PATH as well.
git clone https://chromium.googlesource.com/chromium/tools/depot_tools ~/depot_tools echo 'export PATH="$PATH:$HOME/depot_tools"' >> ~/.bashrc
./presubmit.sh runs three different sets of tests:
./recipes.py test train)./black --diff --check .).recipe_deps/fuchsia/scripts/cleanup_deps.py --check)The formatting check will tell you what‘s wrong but not fix it. For that you need to run ./black .. Similarly, the dependencies check will tell you what’s wrong but you'll need to edit the files to fix issues.
If not using ./presubmit.sh you'll need to run ./scripts/ensure_black.sh before ./black is present.