pw_presubmit: Drop step name from metadata output

When only one step has run, change metadata output like the following:

  "binary_sizes":  {
    "step1.foo": 123,
    "step1.bar": 456,
  }

Into the following:

  "binary_sizes":  {
    "foo": 123,
    "bar": 456,
    "step1.foo": 123,
    "step1.bar": 456,
  }

This is because we might be comparing size outputs from steps with
different names, like how http://go/bbid/8806742220499454865 should have
been compared against http://go/bbid/8806745632315100225, but none of
the keys under "binary_sizes" in the output properties matched.

Keep the step-prefixed values as well because those will persist if
additional steps are added to the builder.

Bug: b/240973086
Change-Id: I9517ea9c6971b97ca2096d494986d27b0e657fb9
Reviewed-on: https://pigweed-review.googlesource.com/c/infra/recipes/+/105042
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
Reviewed-by: Max Koopman <koopman@google.com>
Reviewed-by: Ted Pudlik <tpudlik@google.com>
2 files changed
tree: 727cc6ab996ec7b2e2c5f7e56a5ebf6903af9b02
  1. infra/
  2. recipe_modules/
  3. recipes/
  4. scripts/
  5. .gitignore
  6. .style.yapf
  7. AUTHORS
  8. cipd.ensure
  9. LICENSE
  10. OWNERS
  11. presubmit.sh
  12. pyproject.toml
  13. README.md
  14. recipes.py
README.md

Pigweed Recipes

This repository contains recipes for Pigweed.

A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Pigweed and downstream projects using Pigweed in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Pigweed in your local environment.

See go/pigweed-recipe-docs for complete documentation and a guide for getting started with writing recipes.

Getting the Code

The recommended way to get the source code is with git.

git clone https://pigweed.googlesource.com/infra/recipes

In most cases you will need a Chromium depot_tools checkout in your PATH as well.

git clone https://chromium.googlesource.com/chromium/tools/depot_tools ~/depot_tools
echo 'export PATH="$PATH:$HOME/depot_tools"' >> ~/.bashrc

Running Tests

./presubmit.sh runs three different sets of tests:

  • Recipe expectation tests (./recipes.py test train)
  • Formatting (./black --diff --check .)
  • Dependencies (.recipe_deps/fuchsia/scripts/cleanup_deps.py --check)

The formatting check will tell you what‘s wrong but not fix it. For that you need to run ./black .. Similarly, the dependencies check will tell you what’s wrong but you'll need to edit the files to fix issues.

If not using ./presubmit.sh you'll need to run ./scripts/ensure_black.sh before ./black is present.