| commit | 8543e717aaea8d304ed542cbd8e33b7a3fe649bd | [log] [tgz] |
|---|---|---|
| author | Rob Mohr <mohrr@google.com> | Mon Mar 14 11:54:41 2022 -0700 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 14 20:03:40 2022 +0000 |
| tree | 05fb31f1f39bd85b486443051cae28295d358301 | |
| parent | 3a00c6c9c618ccfa969a24ccceab09040f768fb8 [diff] |
static_checks: Block auto-submit with 'Requires:' If an auto-submit label is set and the commit message description includes 'Requires:' then fail CQ. Implementing in static-checks instead of auto-submit for multiple reasons: * A CQ failure makes things clearer than auto-submit silently ignoring a CL. * Auto-submit is not currently set up to post comments, and auto-submit runs very often so it would need special handling to limit the number of posts of warnings. * Auto-submit is a recipe module defined in another repository managed by a project that doesn't use 'Requires:'. Bug: b/223806446 Change-Id: I73c62fa1379f2e307bcc816195469cfd72227e1c Reviewed-on: https://pigweed-review.googlesource.com/c/infra/recipes/+/88081 Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com> Reviewed-by: Ted Pudlik <tpudlik@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
This repository contains recipes for Pigweed.
A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Pigweed and downstream projects using Pigweed in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Pigweed in your local environment.
See go/pigweed-recipe-docs for complete documentation and a guide for getting started with writing recipes.
The recommended way to get the source code is with git.
git clone https://pigweed.googlesource.com/infra/recipes
In most cases you will need a Chromium depot_tools checkout in your PATH as well.
git clone https://chromium.googlesource.com/chromium/tools/depot_tools ~/depot_tools echo 'export PATH="$PATH:$HOME/depot_tools"' >> ~/.bashrc
./presubmit.sh runs three different sets of tests:
./recipes.py test train)./black --diff --check .).recipe_deps/fuchsia/scripts/cleanup_deps.py --check)The formatting check will tell you what‘s wrong but not fix it. For that you need to run ./black .. Similarly, the dependencies check will tell you what’s wrong but you'll need to edit the files to fix issues.
If not using ./presubmit.sh you'll need to run ./scripts/ensure_black.sh before ./black is present.