Remove 'if TYPE_CHECKING' conditionals in modules

Left 'if TYPE_CHECKING' checks in the bazel, bazel_roll, and cipd_roll
modules, because the checkout module depends on those modules, directly
or indirectly, so these modules can't depend on the checkout module or
the recipe engine will get very angry.

Also fix bad imports that weren't evaluated because they were hidden
under 'if TYPE_CHECKING'.

Change-Id: I908b215045255428fd7a0526030ea5cca7b03852
Reviewed-on: https://pigweed-review.googlesource.com/c/infra/recipes/+/306432
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Commit-Queue: Rob Mohr <mohrr@google.com>
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
Reviewed-by: Oliver Newman <olivernewman@google.com>
46 files changed
tree: 1372e96e344f4878523bb6a58a0e2a7c5d548367
  1. infra/
  2. recipe_modules/
  3. recipes/
  4. scripts/
  5. .aiderignore
  6. .editorconfig
  7. .gitignore
  8. .style.yapf
  9. AUTHORS
  10. GEMINI.md
  11. LICENSE
  12. OWNERS
  13. presubmit.sh
  14. pyproject.toml
  15. README.md
  16. recipes.py
  17. shac.ensure
  18. shac.star
  19. shac.textproto
README.md

Pigweed Recipes

This repository contains recipes for Pigweed.

A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Pigweed and downstream projects using Pigweed in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Pigweed in your local environment.

See go/pigweed-recipe-docs for complete documentation and a guide for getting started with writing recipes.

Getting the Code

The recommended way to get the source code is with git.

git clone https://pigweed.googlesource.com/infra/recipes

In most cases you will need a Chromium depot_tools checkout in your PATH as well.

git clone https://chromium.googlesource.com/chromium/tools/depot_tools ~/depot_tools
echo 'export PATH="$PATH:$HOME/depot_tools"' >> ~/.bashrc

Running Tests

./presubmit.sh runs three different sets of tests:

  • Recipe expectation tests (./recipes.py test train)
  • Formatting (./black --diff --check .)
  • Dependencies (.recipe_deps/fuchsia/scripts/cleanup_deps.py --check)

The formatting check will tell you what‘s wrong but not fix it. For that you need to run ./black .. Similarly, the dependencies check will tell you what’s wrong but you'll need to edit the files to fix issues.

If not using ./presubmit.sh you'll need to run ./scripts/ensure_black.sh before ./black is present.