commit | e1d553cb9f13d5158db06392049c9bc43aef10e8 | [log] [tgz] |
---|---|---|
author | Rob Mohr <mohrr@google.com> | Thu Jan 06 08:30:27 2022 -0800 |
committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jan 06 17:43:59 2022 +0000 |
tree | 0011a0f533c1e895f91109a4bc306ceeb5c2c072 | |
parent | 7911b9f50110a3afa05a88c3a7794c35cfe5f672 [diff] |
pw_presubmit: Handle empty list of steps It's possible that a program doesn't contain any steps that apply to the files modified by a commit. This should result in a passing build, not a failing build. A build with empty values for both the program and step properties will still fail—this only covers when there is a program property but it doesn't expand to any steps. Change-Id: I42408053f9bdcc4509d85cef4f724049abc30d6e Bug: 588 Reviewed-on: https://pigweed-review.googlesource.com/c/infra/recipes/+/77060 Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com> Reviewed-by: Ted Pudlik <tpudlik@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
This repository contains recipes for Pigweed.
A recipe is a Python script that runs a series of commands, using the recipe engine framework from the LUCI project. We use recipes to automatically check out, build, and test Pigweed and downstream projects using Pigweed in continuous integration jobs. The commands the recipes use are very similar to the ones you would use as a developer to check out, build, and test Pigweed in your local environment.
See go/pigweed-recipe-docs for complete documentation and a guide for getting started with writing recipes.
The recommended way to get the source code is with git.
git clone https://pigweed.googlesource.com/infra/recipes
In most cases you will need a Chromium depot_tools checkout in your PATH
as well.
git clone https://chromium.googlesource.com/chromium/tools/depot_tools ~/depot_tools echo 'export PATH="$PATH:$HOME/depot_tools"' >> ~/.bashrc
./presubmit.sh
runs three different sets of tests:
./recipes.py test train
)./black --diff --check .
).recipe_deps/fuchsia/scripts/cleanup_deps.py --check
)The formatting check will tell you what‘s wrong but not fix it. For that you need to run ./black .
. Similarly, the dependencies check will tell you what’s wrong but you'll need to edit the files to fix issues.
If not using ./presubmit.sh
you'll need to run ./scripts/ensure_black.sh
before ./black
is present.