| commit | 061152db438685457cc3b1cbadfcd8a51837b898 | [log] [tgz] |
|---|---|---|
| author | Jonathon Reinhart <jrreinhart@pigweed.infra.roller.google.com> | Mon Sep 16 17:23:58 2024 +0000 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Sep 16 17:23:58 2024 +0000 |
| tree | 86f268b539e173cab9f747889df30a0ae0c21830 | |
| parent | 9c9f1e3a7453be7d12286000aa4fd825a7d48a25 [diff] |
roll: third_party/pigweed pw_spi_linux: Avoid unneccessary ioctl()s in Configure()
Initiator::Configure() is called on every Device::WriteRead() call, in
case different devices on the bus use different configuration.
Avoid unnecessary ioctl() calls by recording the current configuration
and skipping Configure() if the new config is not actually different.
If the pw::spi::Initiator base class were using the non-virtual
interface (NVI) pattern, this could be implemented there and apply to
all initiator implementations.
Test: Verified downstream project still works and redundant ioctls no
longer happen
Original-Bug: 366541694
Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/235877
Original-Revision: eefd313bdb13098552cd713598b937debe80d3d4
Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed
Rolled-Commits: f66eafb0d8d1b5..eefd313bdb1309
Roller-URL: https://ci.chromium.org/b/8736620221636290081
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I21dbc82d6613640adadc0e8dc47c08218085d119
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/examples/+/236194
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
This repository outlines the recommended way of using Pigweed in a new or existing project. Feel free to fork this repository, or read it as a reference.
For more information see the Pigweed Getting started guide.
Check back for more complex examples and features coming soon!
Make sure you've set up Pigweed's prerequisites.
If you're on Windows, you can automate the initial setup by downloading the first-time setup script from cmd.exe:
curl https://pigweed.googlesource.com/pigweed/sample_project/+/main/tools/setup_windows_prerequisites.bat?format=TEXT > setup_pigweed_prerequisites.b64 && certutil -decode -f setup_pigweed_prerequisites.b64 setup_pigweed_prerequisites.bat && del setup_pigweed_prerequisites.b64
Then you can run the script with the following command in cmd.exe:
setup_pigweed_prerequisites.bat
Note: You may see a few UAC prompts as the script installs Git, Python, and enables developer mode.
Once that is done, you can clone this project with the following command:
git clone https://pigweed.googlesource.com/pigweed/sample_project
Pigweed uses a local development environment for most of its tools. This means tools are not installed to your machine, and are instead stored in a directory inside your project (Note: git ignores this directory). The tools are temporarily added to the PATH of the current shell session.
To make sure the latest tooling has been fetched and set up, run the bootstrap command for your operating system:
Windows
bootstrap.bat
Linux & Mac
source ./bootstrap.sh
After tooling updates, you might need to run bootstrap again to ensure the latest tools.
After the initial bootstrap, you can use use the activate scripts to configure the current shell for development without doing a full update.
Windows
activate.bat
Linux & Mac
source ./activate.sh
All of these commands must be run from inside an activated developer environment. See Environment setup
To build the project, documentation, and tests, run the following command in an activated environment:
pw build
Alternatively, if you'd like an automatic rebuild to trigger whenever you save changes to files, use pw watch:
pw watch
When you pull latest repository changes, run bootstrap:
source ./bootstrap.sh
If you're just launching a new shell session, you can activate instead:
source ./activate.sh
and rebuild with:
pw build
Extended documentation and examples are built along code changes. You can view them at out/gn/docs/gen/docs/html/index.html.