roll Skylib
This allows us to get rid of an old TODO.
Change-Id: Ia32af5b090f13115593efe95e299104f9a539460
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/examples/+/210038
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Reviewed-by: Anthony DiGirolamo <tonymd@google.com>
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Commit-Queue: Ted Pudlik <tpudlik@google.com>
diff --git a/WORKSPACE b/WORKSPACE
index 50e3ae2..720a972 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -28,10 +28,10 @@
)
http_archive(
- name = "bazel_skylib", # 2022-09-01
- sha256 = "4756ab3ec46d94d99e5ed685d2d24aece484015e45af303eb3a11cab3cdc2e71",
- strip_prefix = "bazel-skylib-1.3.0",
- urls = ["https://github.com/bazelbuild/bazel-skylib/archive/refs/tags/1.3.0.zip"],
+ name = "bazel_skylib",
+ sha256 = "aede1b60709ac12b3461ee0bb3fa097b58a86fbfdb88ef7e9f90424a69043167",
+ strip_prefix = "bazel-skylib-1.6.1", # 2024-04-24
+ urls = ["https://github.com/bazelbuild/bazel-skylib/archive/refs/tags/1.6.1.tar.gz"],
)
http_archive(
diff --git a/examples/01_blinky/BUILD.bazel b/examples/01_blinky/BUILD.bazel
index 880afa6..03ef75d 100644
--- a/examples/01_blinky/BUILD.bazel
+++ b/examples/01_blinky/BUILD.bazel
@@ -71,12 +71,6 @@
native_binary(
name = "flash_stm32",
src = "//tools:flash_device",
- # TODO: https://github.com/bazelbuild/bazel-skylib/issues/399 - out should
- # be optional.
- #
- # We use the .exe extension for the symlink because it's required on Windows
- # and tolerated on other platforms.
- out = "flash_stm32.exe",
args = [
"--device",
"STM32-Discovery",
@@ -88,7 +82,6 @@
native_binary(
name = "console",
src = "//tools:console",
- out = "console.exe",
args = [
"-d",
"/dev/ttyACM0",
