| commit | 607426d7d08c47c6c19759a5228d58511c622833 | [log] [tgz] |
|---|---|---|
| author | pigweed-roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> | Mon Jul 01 17:43:07 2024 +0000 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jul 01 17:43:07 2024 +0000 |
| tree | 0a2b358ed039bc80b74abbf86f4bd8aaf6f4b9b8 | |
| parent | dea5d4c3c451d733294e9bf9d5cb38b51a407d8b [diff] |
roll: third_party/pigweed: pw_bluetooth_sapphire: Fix LowEnergyScanner crash This includes a fix to a LowEnergyScanner crash. If a scan response timeout occurred before we received a scan response (e.g. scannable peer which responded slowly with a scan response), we would have destroyed all context regarding the peer while still trying to handle the scan response. This handling had a bug where we wouldn't check whether the peer context was still in our memory or had already been destructed. When already destructed, we would access now invalid memory and crash. As a part of this change, we make a large refactor, moving some packet builder methods from FakeController to FakePeer. FakePeer by default sends its advertising reports immediately to facilitate scanning. However, tests can now also request FakePeer to not do so and retain control of sending the advertising reports themselves. This allowed us to write a new test to test the LowEnergyScanner crashed mentioned in the paragraph above. We also clean up some of the code on batching advertising data with scan responses in advertising reports. The majority of the tests followed the simple path of not batching advertising data with scan responses in the advertising reports. For the one case where we wanted to batch the data, we introduce a new test so that we can continue to test such a situation while also simplifying the code. Original-Bug: b/323098126 Test: fx test src/connectivity/bluetooth/core/bt-host; added tests Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/986428 GitOrigin-RevId: 5337de654fa02e9b80c28ac1fe64833c130eadc1 Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/218974 Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com> https://pigweed.googlesource.com/pigweed/pigweed third_party/pigweed Rolled-Commits: 0bff625d0768fe8..194c43b97cef496 Roller-URL: https://ci.chromium.org/b/8743594840577508593 GitWatcher: ignore CQ-Do-Not-Cancel-Tryjobs: true Change-Id: I89894b9a0d3681fbebad1afc50864252f15d4a66 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/examples/+/219276 Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com> Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
This repository outlines the recommended way of using Pigweed in a new or existing project. Feel free to fork this repository, or read it as a reference.
For more information see the Pigweed Getting started guide.
Check back for more complex examples and features coming soon!
Make sure you've set up Pigweed's prerequisites.
If you're on Windows, you can automate the initial setup by downloading the first-time setup script from cmd.exe:
curl https://pigweed.googlesource.com/pigweed/sample_project/+/main/tools/setup_windows_prerequisites.bat?format=TEXT > setup_pigweed_prerequisites.b64 && certutil -decode -f setup_pigweed_prerequisites.b64 setup_pigweed_prerequisites.bat && del setup_pigweed_prerequisites.b64
Then you can run the script with the following command in cmd.exe:
setup_pigweed_prerequisites.bat
Note: You may see a few UAC prompts as the script installs Git, Python, and enables developer mode.
Once that is done, you can clone this project with the following command:
git clone https://pigweed.googlesource.com/pigweed/sample_project
Pigweed uses a local development environment for most of its tools. This means tools are not installed to your machine, and are instead stored in a directory inside your project (Note: git ignores this directory). The tools are temporarily added to the PATH of the current shell session.
To make sure the latest tooling has been fetched and set up, run the bootstrap command for your operating system:
Windows
bootstrap.bat
Linux & Mac
source ./bootstrap.sh
After tooling updates, you might need to run bootstrap again to ensure the latest tools.
After the initial bootstrap, you can use use the activate scripts to configure the current shell for development without doing a full update.
Windows
activate.bat
Linux & Mac
source ./activate.sh
All of these commands must be run from inside an activated developer environment. See Environment setup
To build the project, documentation, and tests, run the following command in an activated environment:
pw build
Alternatively, if you'd like an automatic rebuild to trigger whenever you save changes to files, use pw watch:
pw watch
When you pull latest repository changes, run bootstrap:
source ./bootstrap.sh
If you're just launching a new shell session, you can activate instead:
source ./activate.sh
and rebuild with:
pw build
Extended documentation and examples are built along code changes. You can view them at out/gn/docs/gen/docs/html/index.html.