roll: third_party/pigweed: pw_bluetooth_sapphire: Fix LowEnergyScanner crash
This includes a fix to a LowEnergyScanner crash. If a scan
response timeout occurred before we received a scan response
(e.g. scannable peer which responded slowly with a scan response), we
would have destroyed all context regarding the peer while still trying
to handle the scan response. This handling had a bug where we wouldn't
check whether the peer context was still in our memory or had already
been destructed. When already destructed, we would access now invalid
memory and crash.
As a part of this change, we make a large refactor, moving some packet
builder methods from FakeController to FakePeer. FakePeer by default
sends its advertising reports immediately to facilitate
scanning. However, tests can now also request FakePeer to not do so and
retain control of sending the advertising reports themselves. This
allowed us to write a new test to test the LowEnergyScanner crashed
mentioned in the paragraph above.
We also clean up some of the code on batching advertising data with scan
responses in advertising reports. The majority of the tests followed the
simple path of not batching advertising data with scan responses in the
advertising reports. For the one case where we wanted to batch the data,
we introduce a new test so that we can continue to test such a situation
while also simplifying the code.
Original-Bug: b/323098126
Test: fx test src/connectivity/bluetooth/core/bt-host; added tests
Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/986428
GitOrigin-RevId: 5337de654fa02e9b80c28ac1fe64833c130eadc1
Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/218974
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
https://pigweed.googlesource.com/pigweed/pigweed
third_party/pigweed Rolled-Commits: 0bff625d0768fe8..194c43b97cef496
Roller-URL: https://ci.chromium.org/b/8743594840577508593
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I89894b9a0d3681fbebad1afc50864252f15d4a66
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/examples/+/219276
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
diff --git a/third_party/pigweed b/third_party/pigweed
index 0bff625..194c43b 160000
--- a/third_party/pigweed
+++ b/third_party/pigweed
@@ -1 +1 @@
-Subproject commit 0bff625d0768fe8b1e784b8215236c618e714dbe
+Subproject commit 194c43b97cef4963ffee315c5be14ff5b7c58b8a
