tree 0c8f931b3dcac7bf7e2e558cd7d223d9382ae7dd
parent 468079b954ac3c313b9e82a0e3ea1996d50505d3
author Mingyu Kang <kenkangxgwe@pigweed.infra.roller.google.com> 1782808455 -0700
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> 1782808455 -0700

roll: third_party/pigweed Revert "pw_grpc: Fail Explicitly on Unsupported HPACK Features"

This reverts commit 9bc226447fb0561fb0233bc82a85b0224c78b4fb.

Reason for revert: This uncovers the client side implementation error that it has a race with server settings change

Failure Link: b/529510406

Original change's description:
> pw_grpc: Fail Explicitly on Unsupported HPACK Features
>
> Modify the HPACK parser and connection handler to fail loudly (with
> COMPRESSION_ERROR via GOAWAY) when a client attempts to use HPACK
> dynamic table indexing or dynamic table size updates > 0, since our
> server is stateless and advertises a dynamic table size of 0.
>
> Specifically:
> - Reject indexed header fields with index > 61 (RFC 7541 §6.1).
> - Reject literal header fields with name index > 61 (RFC 7541 §6.2).
> - Reject dynamic table size updates > 0 (RFC 7541 §6.3).
> - Send GOAWAY with COMPRESSION_ERROR on these failures.
>
> Original-Bug: 513566128
> Test: Unit test and manual test
> Change-Id: I879a756b97655b85ed3602c50d3ed1cdd00f914d
> Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/412056

# Not skipping CQ checks because original CL landed > 1 day ago.

Original-Bug: 513566128
Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/430854
Original-Revision: ef4e131f113a657a36539498cc499fbe04512cec

Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed
Rolled-Commits: 2b3947b60a0fff..ef4e131f113a65
Roll-Count: 1
Roller-URL: https://cr-buildbucket.appspot.com/build/8677584584328750305
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I717bf43276e5e6dc94f410593aaa586f25e51435
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/examples/+/430952