tree aa1241144bc3fff786ad9934fd3caa39f4cce48f
parent b0b48eb528dd4e2a44b485e9b43c2b12420dce4d
author Jonathon Reinhart <jrreinhart@pigweed.infra.roller.google.com> 1689016623 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> 1689016623 +0000

[roll third_party/pigweed] pw_system: Make Optional Device constructor args truly optional

Even though detokenizer and timestamp_decoder are annotated as Optional,
no default parameter value (i.e., = None) is provided, so the caller
must still provide an argument.

Add `= None` to allow these arguments to be truly optional.

A cursory look indicates that None is properly handled for both, and
other code is successfully passing None.

The only in-tree use is in pw_system.console which explicitly passes a
value for both args. Update that use-case to pass a named argument for
clarity.

Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/154710

https://pigweed.googlesource.com/pigweed/pigweed
third_party/pigweed Rolled-Commits: c58ca4f0b6dba12..85d2d0d07326298
Roller-URL: https://ci.chromium.org/b/8775931895122237713
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: Ie40b8551cad271fd8cd7e3cf5c2b67caad6d0c2a
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/experimental/+/154545
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>