tree 88523be0cd5e3c278f9b8c91839394053b735b87
parent 8c490047b4de584d1ef04853aae28128ceb7c346
author Wyatt Hepler <hepler@pigweed.infra.roller.google.com> 1731403694 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> 1731403694 +0000

roll: third_party/pigweed pw_channel: Rework inheritance to avoid SiblingCast

Change pw_channel to a new inheritance pattern that places AnyChannel in
the middle of the hierarchy. The various Channel API classes are private
empty bases of AnyChannel. This ensures conversions between compatible
Channel variants are valid, since all channel implementations have all
channel variants as bases. Channel implementations extend a ChannelImpl
with properties specified in template parameters, and unsupported
functions are automatically disabled.

This change also refactors and simplifies the channel.h header.
Properties and code for checking them are moved to a properties.h
header. Also, the macros to generate ChannelImpl specializations are
greatly simplified.

Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/247732
Original-Revision: 0422de1761e52ad5d1fad821880025fc27facf1c

Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed
Rolled-Commits: c521eeca9d3860..0422de1761e52a
Roll-Count: 1
Roller-URL: https://cr-buildbucket.appspot.com/build/8731486066093552033
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I69d25322f1b76406519563a37c4367e671ac9605
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/experimental/+/248256
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>