[roll third_party/pigweed] pw_protobuf: Codegen kConstantCase field enums
pw_protobuf generated code includes an "enum class Fields : uint32_t"
type in in message, with values equal to the IDs for each field in the
message.
Unfortunately, the existing generated code uses SNAKE_CASE for the
names, rather than kConstantCase. In addition to be against the
style guide, this makes collisions with legacy C macros much more
likely.
Indeed, I ran into this issue due to a naming collison on OUTPUT_TYPE
between stm32cube.h and descriptor.pwpb.h. Of course, ST deserves
significant blame here for using inadequately namespaced global
identifiers... it's not just pw_protobuf's fault for not using
kConstantCase.
This commit does not yet migrate pigweed code to use the kConstantCase
values, that will be in an immediate follow-on. However, this commit
DOES add a GN variable to control generation of the legacy
names (in addition to new names):
pw_protobuf_compiler_GENERATE_LEGACY_ENUM_SNAKE_CASE_NAMES
This currently defaults to true, but will change to default to false
after the follow-on commit which migrates upstream pigweed away from
SNAKE_CASE. That will have to be done by an upstream pigweed developer.
Original-Bug: b/266298474
Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/126804
https://pigweed.googlesource.com/pigweed/pigweed
third_party/pigweed Rolled-Commits: 192907f11d0b5b0..0da1c61e72fbaf8
Roller-URL: https://ci.chromium.org/b/8791022914520106065
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I0a89fe56934b0140415b93b0ff0b83f4d2b8bfef
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/experimental/+/126886
Bot-Commit: Pigweed Integration Roller <pigweed-integration-roller@pigweed.google.com.iam.gserviceaccount.com>
Commit-Queue: Pigweed Integration Roller <pigweed-integration-roller@pigweed.google.com.iam.gserviceaccount.com>
diff --git a/third_party/pigweed b/third_party/pigweed
index 192907f..0da1c61 160000
--- a/third_party/pigweed
+++ b/third_party/pigweed
@@ -1 +1 @@
-Subproject commit 192907f11d0b5b07e51d648a62ccde44304c3a96
+Subproject commit 0da1c61e72fbaf8db658ae520097be146b1701c1
