pw_display_driver: remove GetWidth/GetHeight
Remove the unused methods: GetWidth() and GetHeight().
At best these should have been GetMaxWidth/GetMaxHeight,
but some drivers are more complicated as they support only
a few discrete resolutions. For now will remove them and
when the need arises a proper solution will be added.
Bug: none
Change-Id: I22d0b8025d14e0583693de77c9b92b5fe7b2eb63
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/experimental/+/119736
Commit-Queue: Chris Mumford <cmumford@google.com>
Reviewed-by: Anthony DiGirolamo <tonymd@google.com>
GitOrigin-RevId: 44c37d9536dc53d99a2136d6a5399077996cf007
diff --git a/pw_display_driver/public/pw_display_driver/display_driver.h b/pw_display_driver/public/pw_display_driver/display_driver.h
index 6051296..15bc575 100644
--- a/pw_display_driver/public/pw_display_driver/display_driver.h
+++ b/pw_display_driver/public/pw_display_driver/display_driver.h
@@ -32,12 +32,6 @@
// Initialize the display controller.
virtual Status Init() = 0;
- // Return the width supported by the display controller.
- virtual int GetWidth() const = 0;
-
- // Return the height supported by the display controller.
- virtual int GetHeight() const = 0;
-
// Send all pixels in the supplied |framebuffer| to the display controller
// for display.
virtual Status Update(pw::framebuffer::FramebufferRgb565* framebuffer) = 0;
diff --git a/pw_display_driver_ili9341/display_driver.cc b/pw_display_driver_ili9341/display_driver.cc
index 6a1d277..7c4237a 100644
--- a/pw_display_driver_ili9341/display_driver.cc
+++ b/pw_display_driver_ili9341/display_driver.cc
@@ -282,10 +282,6 @@
return OkStatus();
}
-int DisplayDriverILI9341::GetWidth() const { return kDisplayWidth; }
-
-int DisplayDriverILI9341::GetHeight() const { return kDisplayHeight; }
-
Status DisplayDriverILI9341::Update(
pw::framebuffer::FramebufferRgb565* frame_buffer) {
auto transaction =
diff --git a/pw_display_driver_ili9341/public/pw_display_driver_ili9341/display_driver.h b/pw_display_driver_ili9341/public/pw_display_driver_ili9341/display_driver.h
index 1217d86..d67c65f 100644
--- a/pw_display_driver_ili9341/public/pw_display_driver_ili9341/display_driver.h
+++ b/pw_display_driver_ili9341/public/pw_display_driver_ili9341/display_driver.h
@@ -40,8 +40,6 @@
// DisplayDriver implementation:
// The SPI bus must be in 8-bit mode before calling this function.
Status Init() override;
- int GetWidth() const override;
- int GetHeight() const override;
// The SPI bus must be in 16-bit mode before calling this function.
Status Update(pw::framebuffer::FramebufferRgb565* framebuffer);
Status UpdatePixelDouble(pw::framebuffer::FramebufferRgb565* frame_buffer);
