tree feb10daedd611141aad9e6e3df22a04f401ceab5
parent cb78a76f63eeb01b32e09b392b97d18b7114a370
author Scott James Remnant <keybuk@pigweed.infra.roller.google.com> 1655834642 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> 1655834945 +0000

[roll third_party/pigweed] Revert "pw_thread: Add explicit public default ctor for stl::Options"

This reverts commit 2bc2d9b4ea8fe26d5ff8b4a19b3886b64a24635e.

Reason for revert: FreeRTOS threads are not initialized correctly with this CL, and immediately crash

Original change's description:
> pw_thread: Add explicit public default ctor for stl::Options
>
> Without the explicit default public constructor c++20-based compiler
> rejects `stl::Options{}` initialization and allows only `stl::Options()`
> one.
> See this example for the reference: https://godbolt.org/z/K5GWaGsTf.
>
> This CL also prevents to create `thread::Options` using `{}` syntax
> with explicitly defining the empty constructor instead of the default
> one.
> See this example for the reference: https://godbolt.org/z/EP7hTooo8.
>
> Change-Id: I2749198c0f8134f57320d8f91515c45d252bd089
> Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/98101
> Reviewed-by: Wyatt Hepler <hepler@google.com>
> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
> Pigweed-Auto-Submit: Dennis Kormalev <denk@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/98963

https://pigweed.googlesource.com/pigweed/pigweed
third_party/pigweed Rolled-Commits: ea5abc0a7c9cc89..760cf68c30862b6
Roller-URL: https://ci.chromium.org/b/8810725282209591057
Cq-Cl-Tag: roller-builder:pigweed-experimental-roller
Cq-Cl-Tag: roller-bid:8810725282209591057
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: Iaa7d4a3e812c30d5e2b7915459e7874ead9ebf2a
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/experimental/+/99102
Bot-Commit: Pigweed Integration Roller <pigweed-integration-roller@pigweed.google.com.iam.gserviceaccount.com>
Commit-Queue: Pigweed Integration Roller <pigweed-integration-roller@pigweed.google.com.iam.gserviceaccount.com>