tree e432cbc81054947338d60e9340d923ef51bed5d4
parent 6399b8960ffbf830928fbc20a906aa8335df3e0b
author Eli Lipsitz <elipsitz@pigweed.infra.roller.google.com> 1675210048 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> 1675210048 +0000

[roll third_party/pigweed] pw_rust: Make rust_bin tool definition more robust

The existing rust_bin tool definition in the generate_toolchain template
is missing a few critical pieces:

1) depfile generation -- without this, Ninja won't recompile Rust
   targets when a module (rather than the main.rs or lib.rs) changes.
2) Unused GN rust_bin toolchain arguments. rustenv, crate_name,
   crate_type, rustflags, rustdeps, externs all are provided by GN for
   Rust targets and are necessary to get proper compilation,
   dependencies, flags, etc.

This commit adds the missing pieces. The depfile arguments to rustc look
a little bit arbitrary, but they're just what's required to get rustc to
output depfiles that Ninja can understand (borrowed from Fuchsia).

Tested:
  Set some rustflags in a target, verified they're set properly.
  Added a Rust target that depends on a module in another file, verified
  that without this change, changes to that module do not cause a
  rebuild, and after this change, they do.
Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/127013

https://pigweed.googlesource.com/pigweed/pigweed
third_party/pigweed Rolled-Commits: 3865a74f02bb498..b5f05fbb0869ab2
Roller-URL: https://ci.chromium.org/b/8790409024776794305
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: Ia6372c1685ecc2ac3694a160dc54b60c6c85af98
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/experimental/+/127094
Commit-Queue: Pigweed Integration Roller <pigweed-integration-roller@pigweed.google.com.iam.gserviceaccount.com>
Bot-Commit: Pigweed Integration Roller <pigweed-integration-roller@pigweed.google.com.iam.gserviceaccount.com>