tree 4222092b9a3d6359bd5634d8a15697ed5e36d219
parent e2b5e3de67d053b38ebe8a8dbe20aeeade461865
author Wyatt Hepler <hepler@pigweed.infra.roller.google.com> 1674853935 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> 1674853935 +0000

[roll third_party/pigweed] pw_transfer: Set RPC streams directly

Rather than passing the RPC stream to the transfer thread to be moved,
set it directly. pw_rpc call objects are synchronized by pw_rpc, so it
is safe to move them between threads.

With upcoming pw_rpc changes, a thread will wait until an RPC call's
callbacks finish before moving the call object. This could cause
deadlocks in pw_transfer if a packet arrives immediately after the
stream starts, before the transfer thread gets a chance to move the call
object to its final location. The RPC thread would wait for the next
event to be available in the callback, while the transfer thread would
wait to move the new call object out of the next event until the
callback completed, resulting in deadlock. This change avoids this
issue without needing to drop any packets.

Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/126924

https://pigweed.googlesource.com/pigweed/pigweed
third_party/pigweed Rolled-Commits: aaf7aa543ce96de..5b53103e1076a70
Roller-URL: https://ci.chromium.org/b/8790782807073989505
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I4bdaff227f3c54b3011c068bae2d21bda03a1016
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/experimental/+/127008
Bot-Commit: Pigweed Integration Roller <pigweed-integration-roller@pigweed.google.com.iam.gserviceaccount.com>
Commit-Queue: Pigweed Integration Roller <pigweed-integration-roller@pigweed.google.com.iam.gserviceaccount.com>