| commit | 17dd2305fb87a4a7f8998cb8547fc09825574574 | [log] [tgz] |
|---|---|---|
| author | Taylor Cramer <cramertj@pigweed.infra.roller.google.com> | Wed Oct 25 17:05:02 2023 +0000 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Oct 25 17:05:02 2023 +0000 |
| tree | 536129a0112e476b8648b3646d9b8949c1fb4ddd | |
| parent | e03697c64cfc4e31ccd9d715a961ad70de65eb35 [diff] |
[roll third_party/pigweed] pw_multibuf: Fix TrackingAllocatorWithMemory UAF Prior to this commit, TrackingAllocatorWithMemory had a use-after-free due to destroying the `mem_` field prior to the destruction of the parent class allocators which referenced `mem_` and which read from `mem_` in their destructors. This change resolves this issue by making the allocator that references `mem_` a field of TrackingAllocatorWithMemory that will be destroyed prior to `mem_`. Original-Fixed: b/307733567 Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/177694 https://pigweed.googlesource.com/pigweed/pigweed third_party/pigweed Rolled-Commits: 96de268be9cd48f..65ab9e4fde35275 Roller-URL: https://ci.chromium.org/b/8766246454858643521 GitWatcher: ignore CQ-Do-Not-Cancel-Tryjobs: true Change-Id: Ie8f2ad083df141a00c8d630decc41d2cfdcefbc1 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/kudzu/+/177667 Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Make sure you've set up Pigweed's prerequisites.
If you're on Windows, you can automate the initial setup by downloading the first-time setup script from cmd.exe:
curl https://pigweed.googlesource.com/pigweed/sample_project/+/main/tools/setup_windows_prerequisites.bat?format=TEXT > setup_pigweed_prerequisites.b64 && certutil -decode -f setup_pigweed_prerequisites.b64 setup_pigweed_prerequisites.bat && del setup_pigweed_prerequisites.b64
Then you can run the script with the following command in cmd.exe:
setup_pigweed_prerequisites.bat
Note: You may see a few UAC prompts as the script installs Git, Python, and enables developer mode.
Once that is done, you can clone this project with the following command:
git clone https://pigweed.googlesource.com/pigweed/kudzu
Pigweed uses a local development environment for most of its tools. This means tools are not installed to your machine, and are instead stored in a directory inside your project (Note: git ignores this directory). The tools are temporarily added to the PATH of the current shell session.
To make sure the latest tooling has been fetched and set up, run the bootstrap command for your operating system:
Windows
bootstrap.bat
Linux & Mac
source ./bootstrap.sh
After tooling updates, you might need to run bootstrap again to ensure the latest tools.
After the initial bootstrap, you can use use the activate scripts to configure the current shell for development without doing a full update.
Windows
activate.bat
Linux & Mac
source ./activate.sh
Install the pico SDK and tool to flash the device.
pw package install pico_sdk
pw package install picotool
These packages will be built and added to the path automatically. There is no need to add these to the gn arguments.
Install the GLFW OpenGL library
sudo apt install libglfw3-dev libglfw3
Put the following into /usr/lib/udev/rules.d/49-picoprobe.rules
# Pico app mode
SUBSYSTEMS=="usb", ATTRS{idVendor}=="2e8a", ATTRS{idProduct}=="000a", MODE:="0666"
KERNEL=="ttyACM*", ATTRS{idVendor}=="2e8a", ATTRS{idProduct}=="000a", MODE:="0666", SYMLINK+="rp2040"
# RP2 Boot
SUBSYSTEMS=="usb", ATTRS{idVendor}=="2e8a", ATTRS{idProduct}=="0003", MODE:="0666"
KERNEL=="ttyACM*", ATTRS{idVendor}=="2e8a", ATTRS{idProduct}=="0003", MODE:="0666", SYMLINK+="rp2040"
# Picoprobe
SUBSYSTEMS=="usb", ATTRS{idVendor}=="2e8a", ATTRS{idProduct}=="0004", MODE:="0666"
KERNEL=="ttyACM*", ATTRS{idVendor}=="2e8a", ATTRS{idProduct}=="0004", MODE:="0666", SYMLINK+="picoprobe"
This will also symlink /dev/picoprobe and /dev/rp2040 to the respective vendor and product ids.
Apply the above rules with:
sudo udevadm control --reload-rules sudo udevadm trigger
pw build
Run the host app and connect to it via pw-system-console:
./out/gn/host_device_simulator.speed_optimized/obj/applications/badge/bin/badge & \ pw-system-console --socket-addr default \ --proto-globs third_party/pigweed/pw_rpc/echo.proto ; \ killall badge
export ELF=./out/gn/rp2040.size_optimized/obj/applications/badge/bin/badge.elf picotool reboot -f -u && \ sleep 3 && \ picotool load -x $ELF
Connect with pw-system-console:
pw-system-console --verbose \ --baudrate 115200 \ --proto-globs third_party/pigweed/pw_rpc/echo.proto \ --token-databases ./out/gn/rp2040.size_optimized/obj/applications/badge/bin/badge.elf \ --device /dev/rp2040