commit 5a0450d263b7de5e593ed97d4d902b9719977421
author Alexei Frolov <frolv@google.com> Wed Oct 28 21:10:47 2020 -0700
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Apr 12 23:35:50 2021 +0000
tree 37a36fc44be421c6664514e9c61a2ce3926a76ef
parent db0992d39c15747bea91703d3349e318b5dd801a

Re-enable asserts in headers

Several parts of the code had commented-out asserts due to DCHECK not
working in headers or constexpr functions. This updates those to use the
pw_assert light API.

Fixes: 246
Change-Id: I92899045f9dd2188af8d5bbd13472f00a5431b76
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/22820
Commit-Queue: Alexei Frolov <frolv@google.com>
Reviewed-by: Ewout van Bekkum <ewout@google.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>
Reviewed-by: Keir Mierle <keir@google.com>

pw_kvs/public/pw_kvs/flash_memory.h

diff --git a/pw_kvs/public/pw_kvs/flash_memory.h b/pw_kvs/public/pw_kvs/flash_memory.h
index 28fd043..8a3d35d0 100644
--- a/pw_kvs/public/pw_kvs/flash_memory.h
+++ b/pw_kvs/public/pw_kvs/flash_memory.h
@@ -166,7 +166,6 @@
     FlashPartition::Address address_;
   };
 
-  // TODO(pwbug/246): This can be constexpr when tokenized asserts are fixed.
   FlashPartition(
       FlashMemory* flash,
       uint32_t start_sector_index,
@@ -175,7 +174,6 @@
       PartitionPermission permission = PartitionPermission::kReadAndWrite);
 
   // Creates a FlashPartition that uses the entire flash with its alignment.
-  // TODO(pwbug/246): This can be constexpr when tokenized asserts are fixed.
   FlashPartition(FlashMemory* flash)
       : FlashPartition(
             flash, 0, flash->sector_count(), flash->alignment_bytes()) {}
@@ -301,4 +299,4 @@
 };
 
 }  // namespace kvs
-}  // namespace pw
\ No newline at end of file
+}  // namespace pw