tree cc027bccdb5019d8509aa424f2fda9b79a466006
parent aaf7aa543ce96ded8b578fc337a4048ac34750ab
author Wyatt Hepler <hepler@google.com> 1674853215 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> 1674853215 +0000

pw_transfer: Set RPC streams directly

Rather than passing the RPC stream to the transfer thread to be moved,
set it directly. pw_rpc call objects are synchronized by pw_rpc, so it
is safe to move them between threads.

With upcoming pw_rpc changes, a thread will wait until an RPC call's
callbacks finish before moving the call object. This could cause
deadlocks in pw_transfer if a packet arrives immediately after the
stream starts, before the transfer thread gets a chance to move the call
object to its final location. The RPC thread would wait for the next
event to be available in the callback, while the transfer thread would
wait to move the new call object out of the next event until the
callback completed, resulting in deadlock. This change avoids this
issue without needing to drop any packets.

Change-Id: I24b088e36b7712ceda042cdbe80e0b05dec480b7
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/126924
Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com>
Reviewed-by: Alexei Frolov <frolv@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>