tree b6678edf887d0fb045f24aa3c80b02597cda717e
parent b5b75e595334faf5ee4bee7fb6e3a5b92189b630
author Keir Mierle <keir@google.com> 1597783666 -0700
committer CQ Bot Account <commit-bot@chromium.org> 1597871417 +0000

pw_containers: Intrusive list item auto-removal

Previously, it was easy to accidentally have dangling use-after-free
errors with intrusive list items. This patch changes the logic so that
items remove themselves from their parent list during destruction.

Additionally, this changes IntrusiveList<T>::Item's semantics so that
instead of a nullptr to indicating an unlisted element, a self-cycle
indicates unlisted. This leads to more elegant logic.

Change-Id: I5de663f7c67112b4b9465373d64c0d57b05bd892
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/16260
Reviewed-by: Armando Montanez <amontanez@google.com>
Commit-Queue: Keir Mierle <keir@google.com>