tree b926917c945c66026919873d2a32c96c0c134c98
parent ea5abc0a7c9cc89796385e0eb7f472e30cb62d2e
author Scott James Remnant <keybuk@google.com> 1655832409 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> 1655834144 +0000

Revert "pw_thread: Add explicit public default ctor for stl::Options"

This reverts commit 2bc2d9b4ea8fe26d5ff8b4a19b3886b64a24635e.

Reason for revert: FreeRTOS threads are not initialized correctly with this CL, and immediately crash

Original change's description:
> pw_thread: Add explicit public default ctor for stl::Options
>
> Without the explicit default public constructor c++20-based compiler
> rejects `stl::Options{}` initialization and allows only `stl::Options()`
> one.
> See this example for the reference: https://godbolt.org/z/K5GWaGsTf.
>
> This CL also prevents to create `thread::Options` using `{}` syntax
> with explicitly defining the empty constructor instead of the default
> one.
> See this example for the reference: https://godbolt.org/z/EP7hTooo8.
>
> Change-Id: I2749198c0f8134f57320d8f91515c45d252bd089
> Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/98101
> Reviewed-by: Wyatt Hepler <hepler@google.com>
> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
> Pigweed-Auto-Submit: Dennis Kormalev <denk@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I234909b525bd24f40e5461213f510e77a6a3b834
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/98963
Reviewed-by: Wyatt Hepler <hepler@google.com>
Commit-Queue: Wyatt Hepler <hepler@google.com>
Reviewed-by: Scott James Remnant <keybuk@google.com>
Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com>