commit 77f2f358c38a80c41b6cf33a9efb0cfa01bc2607
author Henri Chataing <henrichataing@google.com> Thu Jul 29 14:29:21 2021 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Aug 30 12:52:25 2021 +0000
tree d855f41551abc52a49a9a3ca670dc39740bdd25c
parent f5eba290689dbf3e4c0d4a0836926ffa629427f4

all: Pass clang-tidy modernize-use-bool-literals check

Change-Id: Iddf04fac95d04a4816a0d1d022f04450679377af
No-Docs-Update-Reason: Format fixes
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/56925
Commit-Queue: Henri Chataing <henrichataing@google.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>

.clang-tidy

diff --git a/.clang-tidy b/.clang-tidy
index 3c26cfa..86c2f36 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -13,7 +13,6 @@
     -modernize-return-braced-init-list,
     -modernize-unary-static-assert,
     -modernize-use-auto,
-    -modernize-use-bool-literals,
     -modernize-use-default-member-init,
     -modernize-use-emplace,
     -modernize-use-equals-default,
@@ -62,7 +61,6 @@
 # @ modernize-use-auto:
 #   Advises to use auto when initializing with a cast to
 #   avoid duplicating the type name
-# @ modernize-use-bool-literals:
 # modernize-use-default-member-init:
 #   Note: added in c++11
 #   Advises to use a default initializer in

pw_assert/assert_test.cc

diff --git a/pw_assert/assert_test.cc b/pw_assert/assert_test.cc
index f948bb8..ecbb0c1 100644
--- a/pw_assert/assert_test.cc
+++ b/pw_assert/assert_test.cc
@@ -40,13 +40,13 @@
 // then disable the test.
 
 TEST(Assert, AssertFalse) {
-  if (0) {
+  if (false) {
     PW_ASSERT(false);
   }
 }
 
 TEST(Assert, DebugAssertFalse) {
-  if (0) {
+  if (false) {
     PW_DASSERT(false);
   }
 }

pw_assert_basic/basic_handler.cc

diff --git a/pw_assert_basic/basic_handler.cc b/pw_assert_basic/basic_handler.cc
index be87baa..cbb0b07 100644
--- a/pw_assert_basic/basic_handler.cc
+++ b/pw_assert_basic/basic_handler.cc
@@ -153,7 +153,7 @@
       WriteLine("");
       WriteLine(
           "     ... until a debugger joins. System is waiting in a while(1)");
-      while (1) {
+      while (true) {
       }
     }
     PW_UNREACHABLE;