tree 6688ed090617b2996b2e769955de90fb1dc9c889
parent 89056eab62bab00fd86835e974004d6259ab2a1f
author Eli Lipsitz <elipsitz@google.com> 1664238712 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> 1664238712 +0000

pw_software_update: Fix recursive lock acquisition in nanopb service

This commit fixes the same recursive lock acquisition as
I0ee7994fa5e093a05e349876406d0a2bd89fc3e7, in the nanopb software update
service.

The NotifyTransferSucceeded method acquires the same lock, leading to a
recursive lock acquisition. This commit fixes the issue by
by moving the outer lock acquisition into
the if statement that calls SET_ERROR, which is mutually exclusive with
the call to NotifyTransferSucceeded.

Change-Id: I30db9cc47ceca8af5b724018ee8b29cef6fc58cd
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/112114
Pigweed-Auto-Submit: Eli Lipsitz <elipsitz@google.com>
Reviewed-by: Ali Zhang <alizhang@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>