tree c13f338ed0910fcf8fc34666f1839fd69bac2de2
parent a06939d49ff44aa14fd5cb907dfe9d09963262e3
author Wyatt Hepler <hepler@google.com> 1641495950 -0800
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> 1641506674 +0000

pw_rpc: Locking improvements

- Expand locking annotations for internal::Call class members.
- Have the ChannelOutput::Send call release the RPC lock right before
  sending the packet. This ensures the Call object's OutputBuffer
  reference is cleared while the lock is held.
- Avoid holding the RPC lock while logging.
- Clear the encoding buffer in FakeChannelOutput to catch code that
  uses stale references.
- Have FakeChannelOutput check that its buffers are properly acquired
  and released.
- Mark PayloadBuffer() as [[nodiscard]].

Change-Id: I948e4ab531f45f424f2cd8cd3fa671bbb1509a85
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/76640
Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com>
Reviewed-by: Alexei Frolov <frolv@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>