commit bee840f3cf39fe296e95202f27b701beec48f58f
author Wyatt Hepler <hepler@google.com> Mon Sep 26 22:23:12 2022 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Sep 26 22:23:12 2022 +0000
tree 2d0b0949e225bd79e3f5551431e84457b8b231e3
parent 72940d68c20122e1829d1be9c421b9d36ec02bc0

pw_rpc: Delete dead code for raw sync RPCs

The raw synchronous API was removed a while ago, but some dead code
remained behind.

Change-Id: I4c7db7e7fbfc6ed884b7f34a0ba40ec94e4223a5
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/112011
Reviewed-by: Alexei Frolov <frolv@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com>

pw_rpc/raw/method.cc

diff --git a/pw_rpc/raw/method.cc b/pw_rpc/raw/method.cc
index 0bff460..14ebfb3 100644
--- a/pw_rpc/raw/method.cc
+++ b/pw_rpc/raw/method.cc
@@ -21,25 +21,6 @@
 
 namespace pw::rpc::internal {
 
-void RawMethod::SynchronousUnaryInvoker(const CallContext& context,
-                                        const Packet& request) {
-  RawUnaryResponder responder(context.ClaimLocked());
-  rpc_lock().unlock();
-  // TODO(hepler): Remove support for raw synchronous unary methods. Unlike
-  //     synchronous Nanopb methods, they provide little value compared to
-  //     asynchronous unary methods. For now, just provide a fixed buffer on the
-  //     stack.
-  std::byte payload_buffer[64] = {};
-
-  StatusWithSize sws =
-      static_cast<const RawMethod&>(context.method())
-          .function_.synchronous_unary(
-              context.service(), request.payload(), span(payload_buffer));
-
-  responder.Finish(span(payload_buffer, sws.size()), sws.status())
-      .IgnoreError();
-}
-
 void RawMethod::AsynchronousUnaryInvoker(const CallContext& context,
                                          const Packet& request) {
   RawUnaryResponder responder(context.ClaimLocked());

pw_rpc/raw/public/pw_rpc/raw/internal/method.h

diff --git a/pw_rpc/raw/public/pw_rpc/raw/internal/method.h b/pw_rpc/raw/public/pw_rpc/raw/internal/method.h
index 0ab0222..0d02d4a 100644
--- a/pw_rpc/raw/public/pw_rpc/raw/internal/method.h
+++ b/pw_rpc/raw/public/pw_rpc/raw/internal/method.h
@@ -115,10 +115,6 @@
   constexpr RawMethod(uint32_t id, Invoker invoker, Function function)
       : Method(id, invoker), function_(function) {}
 
-  static void SynchronousUnaryInvoker(const CallContext& context,
-                                      const Packet& request)
-      PW_UNLOCK_FUNCTION(rpc_lock());
-
   static void AsynchronousUnaryInvoker(const CallContext& context,
                                        const Packet& request)
       PW_UNLOCK_FUNCTION(rpc_lock());