| commit | 46893a2c0fc712a98d9fd0ce7b01136d2476b900 | [log] [tgz] |
|---|---|---|
| author | Aaron Green <aarongreen@pigweed.infra.roller.google.com> | Thu Oct 17 18:23:22 2024 +0000 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Oct 17 18:23:22 2024 +0000 |
| tree | f98f5c9baf2a00b4840e79e8872f0f151de5d4fb | |
| parent | dcbf1e99d811449a04fa92b84108d8d34d635f1a [diff] |
roll: pigweed pw_allocator: Fix data race Prior to this CL, a corruption existed in the following scenario: - Block 1 is allocated. - Block 2 is allocated with an alignment requirement that results in a small gap of less than a minimumu-sized block between blocks 1 and 2. The extra bytes are added to the end of block 1. - Block 1 is resized to be slightly bigger by less than the extra bytes. Since the block size does not change, `Resize` trivially returns. - Block 2 is freed, and reclaims the bytes it lent to block 1. - Block 1 tries to access its trailing bytes concurrently with a new block being allocated. The fix is simply to update the tracked number of extra bytes, even when the `Resize` is trivial. Original-Bug: 372446436 Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/242736 Original-Revision: 57183dee645126c67dcccbb479c730492ef168f6 Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed Rolled-Commits: 8e0d91c3f7da31..57183dee645126 Roll-Count: 1 Roller-URL: https://ci.chromium.org/b/8733807474633820033 GitWatcher: ignore CQ-Do-Not-Cancel-Tryjobs: true Change-Id: Ib10f19ee38f4f903c9afc9a73afdbfa2c191b968 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/quickstart/bazel/+/242921 Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
This repository contains a minimal example of a Bazel-based Pigweed project. It is a LED-blinking service (featuring RPC control!) for the Raspberry Pi Pico. It can also be run on any computer using the included simulator.
git clone https://pigweed.googlesource.com/pigweed/quickstart/bazel pw_bazel_quickstart cd pw_bazel_quickstart
The only dependency that must be installed is Bazelisk.
Bazelisk is a launcher for the Bazel build system that allows for easy management of multiple Bazel versions.
Instructions for installing Bazelisk can be found here.
To run the simulator, type: bazelisk run //apps/blinky:simulator_blinky Then, in a new console, connect to the simulator using: bazelisk run //apps/blinky:simulator_console
To start, connect a Raspberry Pi Pico, Pico 2, or debug probe via USB.
To run on the Raspberry Pi Pico, type: bazelisk run //apps/blinky:flash_rp2040 Then, in a new console, connect to the device using: bazelisk run //apps/blinky:rp2040_console
Once connected with a console, RPCs can be sent to control the LED. Try running:
device.set_led(True) device.set_led(False) device.toggle_led() device.blink(blink_count=3)
bazelisk test //... will run the unit tests defined in this project, such as the ones in modules/blinky/blinky_test.cc.
bazelisk run @pigweed//targets/rp2040/py:unit_test_server in one console followed by bazelisk test //... --config=rp2040 will also allow running the unit tests on-device.
Try poking around the codebase for inspiration about how Pigweed projects can be organized. Most of the relevant code in this quickstart (including RPC definitions) is inside modules/blinky, with some client-side Python code in tools/console.py.