tree e5365bb97a93d5a9fa027bb43cad144a26624378
parent 5d696ee31852481cb1b6d9358198b6ed348a9df9
author Jonathon Reinhart <jrreinhart@pigweed.infra.roller.google.com> 1743453152 -0700
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> 1743453152 -0700

roll: pigweed pw_console: Remove SO_REUSEPORT from SocketClient

SO_REUSEPORT is intended [1] for load-balancing of TCP and UDP servers,
not for the typical problem of re-opening a socket (due to TCP
TIME_WAIT).

Not only is SO_REUSEPORT inappropriate here, but recent kernels have
started restricting [2] it to INET sockets, and attempts to set it on a
UNIX domain socket now return EOPNOTSUPP, causing an exception here.

* [1] https://man7.org/linux/man-pages/man7/socket.7.html
* [2] https://github.com/torvalds/linux/commit/5b0af621c3f6ef9261cf6067812f2fd9943acb4b

Test: Running 'pw console' works again on machines where this was
  crashing with  "Operation not supported".
Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/280332
Tests-Not-Needed: Jonathon Reinhart <jrreinhart@google.com>
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Original-Revision: 90e30c56f1307574faeaec808a657e985fc872ae

Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed
Rolled-Commits: 6985a85e5cc6b0..90e30c56f13075
Roll-Count: 1
Roller-URL: https://cr-buildbucket.appspot.com/build/8718850832557232625
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I7bd6ad4ec3fdecfd3ba73aced8cdcd95ab48bb6a
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/quickstart/bazel/+/280412
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>