roll: pigweed, pw_toolchain: pw_bluetooth_sapphire: Fix LowEnergyScanner crash
This includes a fix to a LowEnergyScanner crash. If a scan
response timeout occurred before we received a scan response
(e.g. scannable peer which responded slowly with a scan response), we
would have destroyed all context regarding the peer while still trying
to handle the scan response. This handling had a bug where we wouldn't
check whether the peer context was still in our memory or had already
been destructed. When already destructed, we would access now invalid
memory and crash.
As a part of this change, we make a large refactor, moving some packet
builder methods from FakeController to FakePeer. FakePeer by default
sends its advertising reports immediately to facilitate
scanning. However, tests can now also request FakePeer to not do so and
retain control of sending the advertising reports themselves. This
allowed us to write a new test to test the LowEnergyScanner crashed
mentioned in the paragraph above.
We also clean up some of the code on batching advertising data with scan
responses in advertising reports. The majority of the tests followed the
simple path of not batching advertising data with scan responses in the
advertising reports. For the one case where we wanted to batch the data,
we introduce a new test so that we can continue to test such a situation
while also simplifying the code.
Original-Bug: b/323098126
Test: fx test src/connectivity/bluetooth/core/bt-host; added tests
Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/986428
GitOrigin-RevId: 5337de654fa02e9b80c28ac1fe64833c130eadc1
Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/218974
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
https://pigweed.googlesource.com/pigweed/pigweed
pigweed, pw_toolchain Rolled-Commits: 0bff625d0768fe8..194c43b97cef496
Roller-URL: https://ci.chromium.org/b/8743594830331743249
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: Ic26c508f7d3db002f009761fe3f2d30f6d09fa0b
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/quickstart/bazel/+/218788
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
diff --git a/WORKSPACE b/WORKSPACE
index efd3160..b7da656 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -83,18 +83,18 @@
git_repository(
name = "pigweed",
# ROLL: Warning: this entry is automatically updated.
- # ROLL: Last updated 2024-06-30.
- # ROLL: By https://cr-buildbucket.appspot.com/build/8743730800674425857.
- commit = "0bff625d0768fe8b1e784b8215236c618e714dbe",
+ # ROLL: Last updated 2024-07-01.
+ # ROLL: By https://cr-buildbucket.appspot.com/build/8743594830331743249.
+ commit = "194c43b97cef4963ffee315c5be14ff5b7c58b8a",
remote = "https://pigweed.googlesource.com/pigweed/pigweed.git",
)
git_repository(
name = "pw_toolchain",
# ROLL: Warning: this entry is automatically updated.
- # ROLL: Last updated 2024-06-30.
- # ROLL: By https://cr-buildbucket.appspot.com/build/8743730800674425857.
- commit = "0bff625d0768fe8b1e784b8215236c618e714dbe",
+ # ROLL: Last updated 2024-07-01.
+ # ROLL: By https://cr-buildbucket.appspot.com/build/8743594830331743249.
+ commit = "194c43b97cef4963ffee315c5be14ff5b7c58b8a",
remote = "https://pigweed.googlesource.com/pigweed/pigweed.git",
strip_prefix = "pw_toolchain_bazel",
)
