| commit | 92a98fbe0feb64fc2fdc7afb9fdd764b52268cc9 | [log] [tgz] |
|---|---|---|
| author | Austin Foxley <afoxley@pigweed.infra.roller.google.com> | Fri Oct 04 21:05:32 2024 +0000 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Oct 04 21:05:32 2024 +0000 |
| tree | b14b81e2b722753ba309f39f2fe08641357fa6a7 | |
| parent | 94a778d94e76dad9b7eada890828b31a7a6958a7 [diff] |
roll: pigweed pw_rpc: Fix Call not getting reset on default constructor assignment
When trying to reinitialize an already used Call object to default,
the move constructor runs but ends up exiting early before actually
resetting the call internal state due to this conditional:
if (!other.active_locked()) {
return; // Nothing else to do; this call is already closed.
}
A default Call has state_ initialized to 0, so active_locked()
returns false so none of the assignments happen on `this`.
We fix this by letting the bulk of the move assignments happen
regardless of active state, except for those parts that apply
specifically to active calls.
Original-Bug: 371211198
Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/239718
Original-Revision: 05e93dadc080e45d624d92b80879297cfade417c
Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed
Rolled-Commits: 2e91930eff5ffa..05e93dadc080e4
Roller-URL: https://ci.chromium.org/b/8734974952960605441
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: Iab564f0965864f8586fba0b721f89a5b2f2e0895
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/quickstart/bazel/+/240232
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
This repository contains a minimal example of a Bazel-based Pigweed project. It is a LED-blinking service (featuring RPC control!) for the Raspberry Pi Pico. It can also be run on any computer using the included simulator.
git clone https://pigweed.googlesource.com/pigweed/quickstart/bazel pw_bazel_quickstart cd pw_bazel_quickstart
The only dependency that must be installed is Bazelisk.
Bazelisk is a launcher for the Bazel build system that allows for easy management of multiple Bazel versions.
Instructions for installing Bazelisk can be found here.
To run the simulator, type: bazelisk run //apps/blinky:simulator_blinky Then, in a new console, connect to the simulator using: bazelisk run //apps/blinky:simulator_console
To start, connect a Raspberry Pi Pico, Pico 2, or debug probe via USB.
To run on the Raspberry Pi Pico, type: bazelisk run //apps/blinky:flash_rp2040 Then, in a new console, connect to the device using: bazelisk run //apps/blinky:rp2040_console
Once connected with a console, RPCs can be sent to control the LED. Try running:
device.set_led(True) device.set_led(False) device.toggle_led() device.blink(blink_count=3)
bazelisk test //... will run the unit tests defined in this project, such as the ones in modules/blinky/blinky_test.cc.
bazelisk run @pigweed//targets/rp2040/py:unit_test_server in one console followed by bazelisk test //... --config=rp2040 will also allow running the unit tests on-device.
Try poking around the codebase for inspiration about how Pigweed projects can be organized. Most of the relevant code in this quickstart (including RPC definitions) is inside modules/blinky, with some client-side Python code in tools/console.py.