tree 286e1378685236f1966b14886762d88fba53192c
parent 1534ecf2d4bb3fd7141314feb300fccd77ae26fe
author Anthony DiGirolamo <tonymd@pigweed.infra.roller.google.com> 1728423709 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> 1728423709 +0000

roll: pigweed pw_console: Fix progress bar division by zero

In some cases it is possible to render a pw_console progress bar while
the elapsed time is still zero. This causes a divide by zero error:

  File
  ".../python-venv/lib/site-packages/prompt_toolkit/shortcuts/progress_bar/formatters.py",
  line 325, in <listcomp>
    len(f"{c.items_completed / c.time_elapsed.total_seconds():.2f}")
Exception float division by zero

The background on why this is an issue is that pw_console removes the
required context manager of prompt_toolkits progress bar
implementation:
https://github.com/prompt-toolkit/python-prompt-toolkit/blob/master/src/prompt_toolkit/shortcuts/progress_bar/base.py#L6
So new runtime errors are possible depending on how the pw_console
start_progress and update_progress functions are
used. https://cs.opensource.google/pigweed/pigweed/+/main:pw_console/py/pw_console/progress_bar/__init__.py

Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/233033
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Original-Revision: 8bd77aba07ab3dce5220b23994cd3ecfbcefda10

Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed
Rolled-Commits: 28288477f008c6..8bd77aba07ab3d
Roller-URL: https://ci.chromium.org/b/8734611505683033809
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I202aee96a773154093e76c76747821659cc7af28
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/quickstart/bazel/+/240647
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>