| commit | 7323e0831eb89d2d8edacb3f0f8379b62951b99a | [log] [tgz] |
|---|---|---|
| author | Austin Foxley <afoxley@pigweed.infra.roller.google.com> | Fri Nov 15 05:37:35 2024 +0000 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Nov 15 05:37:35 2024 +0000 |
| tree | 4c83c13d4e4e96397f3a9580a37b22cb7b5f2eee | |
| parent | 6b0a345155a08392ed7c8f1980bc372d97f02ad1 [diff] |
roll: pigweed pw_bluetooth: Fix RFCOMM information length off by one A misreading of the spec led to confusion on whether credits was counted as part of information_length. It is _not_, but it is included in the calculation for max allowed payload. Fix this and standardize on `information` as the name used in the spec vs payload. Also add helper flag for checking whether a frame is UIH or not Add standalone unit tests for RFCOMM. Original-Bug: 378692444 Original-Bug: 378691959 Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/249092 Original-Revision: 40d4c1261275065d30e77ea68fbea69061b70e78 Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed Rolled-Commits: 5b5c7815e957d3..40d4c126127506 Roll-Count: 1 Roller-URL: https://cr-buildbucket.appspot.com/build/8731228243700534209 GitWatcher: ignore CQ-Do-Not-Cancel-Tryjobs: true Change-Id: Idf410896bd3f2b3ba9eadbcb822d30240a9c820e Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/quickstart/bazel/+/248651 Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com> Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
This repository contains a minimal example of a Bazel-based Pigweed project. It is a LED-blinking service (featuring RPC control!) for the Raspberry Pi Pico. It can also be run on any computer using the included simulator.
git clone https://pigweed.googlesource.com/pigweed/quickstart/bazel pw_bazel_quickstart cd pw_bazel_quickstart
The only dependency that must be installed is Bazelisk.
Bazelisk is a launcher for the Bazel build system that allows for easy management of multiple Bazel versions.
Instructions for installing Bazelisk can be found here.
To run the simulator, type: bazelisk run //apps/blinky:simulator_blinky Then, in a new console, connect to the simulator using: bazelisk run //apps/blinky:simulator_console
To start, connect a Raspberry Pi Pico, Pico 2, or debug probe via USB.
To run on the Raspberry Pi Pico, type: bazelisk run //apps/blinky:flash_rp2040 Then, in a new console, connect to the device using: bazelisk run //apps/blinky:rp2040_console
Once connected with a console, RPCs can be sent to control the LED. Try running:
device.set_led(True) device.set_led(False) device.toggle_led() device.blink(blink_count=3)
bazelisk test //... will run the unit tests defined in this project, such as the ones in modules/blinky/blinky_test.cc.
bazelisk run @pigweed//targets/rp2040/py:unit_test_server in one console followed by bazelisk test //... --config=rp2040 will also allow running the unit tests on-device.
Try poking around the codebase for inspiration about how Pigweed projects can be organized. Most of the relevant code in this quickstart (including RPC definitions) is inside modules/blinky, with some client-side Python code in tools/console.py.