roll: pigweed pw_rpc: Fix Call not getting reset on default constructor assignment
When trying to reinitialize an already used Call object to default,
the move constructor runs but ends up exiting early before actually
resetting the call internal state due to this conditional:
if (!other.active_locked()) {
return; // Nothing else to do; this call is already closed.
}
A default Call has state_ initialized to 0, so active_locked()
returns false so none of the assignments happen on `this`.
We fix this by letting the bulk of the move assignments happen
regardless of active state, except for those parts that apply
specifically to active calls.
Original-Bug: 371211198
Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/239718
Original-Revision: 05e93dadc080e45d624d92b80879297cfade417c
Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed
Rolled-Commits: 2e91930eff5ffa..05e93dadc080e4
Roller-URL: https://ci.chromium.org/b/8734974952960605441
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: Iab564f0965864f8586fba0b721f89a5b2f2e0895
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/quickstart/bazel/+/240232
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
diff --git a/MODULE.bazel b/MODULE.bazel
index fa9d788..d385a15 100644
--- a/MODULE.bazel
+++ b/MODULE.bazel
@@ -49,8 +49,8 @@
module_name = "pigweed",
# ROLL: Warning: this entry is automatically updated.
# ROLL: Last updated 2024-10-04.
- # ROLL: By https://cr-buildbucket.appspot.com/build/8734975660922652321.
- commit = "2e91930eff5ffa17a7f7f5d6a833362194bd1664",
+ # ROLL: By https://cr-buildbucket.appspot.com/build/8734974952960605441.
+ commit = "05e93dadc080e45d624d92b80879297cfade417c",
remote = "https://pigweed.googlesource.com/pigweed/pigweed",
)
@@ -58,8 +58,8 @@
module_name = "pw_toolchain",
# ROLL: Warning: this entry is automatically updated.
# ROLL: Last updated 2024-10-04.
- # ROLL: By https://cr-buildbucket.appspot.com/build/8734975660922652321.
- commit = "2e91930eff5ffa17a7f7f5d6a833362194bd1664",
+ # ROLL: By https://cr-buildbucket.appspot.com/build/8734974952960605441.
+ commit = "05e93dadc080e45d624d92b80879297cfade417c",
remote = "https://pigweed.googlesource.com/pigweed/pigweed",
strip_prefix = "pw_toolchain_bazel",
)
