| commit | 449fe0aca03a2ad7baadd43d4b166b4f3d71fc84 | [log] [tgz] |
|---|---|---|
| author | pigweed-roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> | Mon Jul 01 17:40:46 2024 +0000 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jul 01 17:40:46 2024 +0000 |
| tree | 3c02b5d1546a5e2611307a1c030a5d81c585c9ae | |
| parent | 27a1404798ab0e197bb2698d2b15e4ca5f968100 [diff] |
roll: pigweed, pw_toolchain: pw_bluetooth_sapphire: Fix LowEnergyScanner crash This includes a fix to a LowEnergyScanner crash. If a scan response timeout occurred before we received a scan response (e.g. scannable peer which responded slowly with a scan response), we would have destroyed all context regarding the peer while still trying to handle the scan response. This handling had a bug where we wouldn't check whether the peer context was still in our memory or had already been destructed. When already destructed, we would access now invalid memory and crash. As a part of this change, we make a large refactor, moving some packet builder methods from FakeController to FakePeer. FakePeer by default sends its advertising reports immediately to facilitate scanning. However, tests can now also request FakePeer to not do so and retain control of sending the advertising reports themselves. This allowed us to write a new test to test the LowEnergyScanner crashed mentioned in the paragraph above. We also clean up some of the code on batching advertising data with scan responses in advertising reports. The majority of the tests followed the simple path of not batching advertising data with scan responses in the advertising reports. For the one case where we wanted to batch the data, we introduce a new test so that we can continue to test such a situation while also simplifying the code. Original-Bug: b/323098126 Test: fx test src/connectivity/bluetooth/core/bt-host; added tests Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/986428 GitOrigin-RevId: 5337de654fa02e9b80c28ac1fe64833c130eadc1 Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/218974 Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com> https://pigweed.googlesource.com/pigweed/pigweed pigweed, pw_toolchain Rolled-Commits: 0bff625d0768fe8..194c43b97cef496 Roller-URL: https://ci.chromium.org/b/8743594830331743249 GitWatcher: ignore CQ-Do-Not-Cancel-Tryjobs: true Change-Id: Ic26c508f7d3db002f009761fe3f2d30f6d09fa0b Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/quickstart/bazel/+/218788 Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
This repository contains a minimal example of a Bazel-based Pigweed project. It's an echo application for the STM32F429 Discovery Board.
git clone --recursive https://pigweed.googlesource.com/pigweed/quickstart/bazel
If you already cloned but forgot to include --recursive, run git submodule update --init to pull all submodules.
TODO: b/300695111 - Don't require submodules for this example.
We‘ll assume you already have Bazel on your system. If you don’t, the recommended way to get it is through Bazelisk.
To build the entire project (including building the application for both the host and the STM32 Discovery Board), run
bazel build //...
To run the application locally on your machine, run,
bazel run //src:echo
To flash the firmware to a STM32F429 Discovery Board connected to your machine, run,
bazel run //tools:flash
Note that you don't need to build the firmware first: Bazel knows that the firmware images are needed to flash the board, and will build them for you. And if you edit the source of the firmware or any of its dependencies, it will get rebuilt when you flash.
Run,
bazel run //tools:miniterm -- /dev/ttyACM0 --filter=debug
to communicate with the board. When you transmit a character, you should get the same character back!