commit | f28c16e79a8441f2a8089753954bcddd713a547f | [log] [tgz] |
---|---|---|
author | Aaron Green <aarongreen@pigweed.infra.roller.google.com> | Mon Sep 23 20:05:29 2024 +0000 |
committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Sep 23 20:05:29 2024 +0000 |
tree | fbccea096473617ece38ebfe5a7ca8a79a1ad700 | |
parent | 051d6cafe65baa424dfb2c257f4d73705e340d99 [diff] |
roll: pigweed pw_containers: Fix tree rebalancing `AATreeItem::Rebalance` did not correctly update the parent of a node when rebalancing a subtree. As a result, when the subtree root was rebalanced into a different position, such as a leaf node, other nodes could become orphaned. The unit tests did not include enough items to encounter this error. The default number of items has been doubled, which triggers the error without the corresponding fix. Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/237415 Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Original-Revision: 92ab0326113d1d6732a6d81dcc25abb330053b22 Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed Rolled-Commits: 4c5e994df70ef9..92ab0326113d1d Roller-URL: https://ci.chromium.org/b/8735975599068836753 GitWatcher: ignore CQ-Do-Not-Cancel-Tryjobs: true Change-Id: I64654560f8239c3dae01b2f746ee8a3ded981305 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/quickstart/bazel/+/237364 Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com> Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
This repository contains a minimal example of a Bazel-based Pigweed project. It is a LED-blinking service (featuring RPC control!) for the Raspberry Pi Pico. It can also be run on any computer using the included simulator.
git clone https://pigweed.googlesource.com/pigweed/quickstart/bazel pw_bazel_quickstart cd pw_bazel_quickstart
The only dependency that must be installed is Bazelisk.
Bazelisk is a launcher for the Bazel build system that allows for easy management of multiple Bazel versions.
Instructions for installing Bazelisk can be found here.
To run the simulator, type: bazelisk run //apps/blinky:simulator_blinky
Then, in a new console, connect to the simulator using: bazelisk run //apps/blinky:simulator_console
To start, connect a Raspberry Pi Pico, Pico 2, or debug probe via USB.
To run on the Raspberry Pi Pico, type: bazelisk run //apps/blinky:flash_rp2040
Then, in a new console, connect to the device using: bazelisk run //apps/blinky:rp2040_console
Once connected with a console, RPCs can be sent to control the LED. Try running:
device.set_led(True) device.set_led(False) device.toggle_led() device.blink(blink_count=3)
bazelisk test //...
will run the unit tests defined in this project, such as the ones in modules/blinky/blinky_test.cc
.
bazelisk run @pigweed//targets/rp2040/py:unit_test_server
in one console followed by bazelisk test //... --config=rp2040
will also allow running the unit tests on-device.
Try poking around the codebase for inspiration about how Pigweed projects can be organized. Most of the relevant code in this quickstart (including RPC definitions) is inside modules/blinky
, with some client-side Python code in tools/console.py
.