Google Git
Sign in
pigweed / pigweed / quickstart / bazel / e98291d19de23c7e8838aa807e909747f4803b1e
commite98291d19de23c7e8838aa807e909747f4803b1e[log] [tgz]
authorJonathon Reinhart <jrreinhart@pigweed.infra.roller.google.com>Thu Jun 27 20:55:50 2024 +0000
committerCQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jun 27 20:55:50 2024 +0000
tree297bc542561bcbc41fe7c367332ec2d17a501392
parentdc0741826782e27fe9a1e5f68ad33a5b8774dc5d [diff]
roll: pigweed, pw_toolchain: pw_build_mcuxpresso: Fix bug in create_project()

create_project() was manipulating the caller-provided 'include' list,
as a result of just assigning a reference to pending_list. This resulted
in surprising behavior when calling e.g. Project.from_file() multiple
times with the same inclue list, but the list was empty the second time.

This fixes that bug by making a copy of the list before mutating it.

This also relaxes the 'include' and 'exclude' parameter types from
list[str] to Collection[str] (sized, iterable) and Container[str]
(has __contains__), accordingly. This helps prevent said bug by not
assuming those parameters are mutable.

Test: Run downstream script which passes the same list multiple times.
Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/218272
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>

https://pigweed.googlesource.com/pigweed/pigweed
pigweed, pw_toolchain Rolled-Commits: e948e9628ef9649..f24d35840b04d28
Roller-URL: https://ci.chromium.org/b/8743944550679323857
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I9acada6a46af89db4d7e3a9b3785d30a3f3467e2
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/quickstart/bazel/+/218752
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
1 file changed
tree: 297bc542561bcbc41fe7c367332ec2d17a501392
  1. .github/
  2. src/
  3. targets/
  4. tools/
  5. .bazelignore
  6. .bazelrc
  7. .bazelversion
  8. .gitignore
  9. BUILD.bazel
  10. echo.bzl
  11. LICENSE
  12. pigweed.json
  13. README.md
  14. requirements.in
  15. requirements_lock.txt
  16. WORKSPACE
README.md

Pigweed: minimal Bazel example

This repository contains a minimal example of a Bazel-based Pigweed project. It's an echo application for the STM32F429 Discovery Board.

Cloning

git clone --recursive https://pigweed.googlesource.com/pigweed/quickstart/bazel

If you already cloned but forgot to include --recursive, run git submodule update --init to pull all submodules.

TODO: b/300695111 - Don't require submodules for this example.

Building

We‘ll assume you already have Bazel on your system. If you don’t, the recommended way to get it is through Bazelisk.

To build the entire project (including building the application for both the host and the STM32 Discovery Board), run

bazel build //...

To run the application locally on your machine, run,

bazel run //src:echo

Flashing

To flash the firmware to a STM32F429 Discovery Board connected to your machine, run,

bazel run //tools:flash

Note that you don't need to build the firmware first: Bazel knows that the firmware images are needed to flash the board, and will build them for you. And if you edit the source of the firmware or any of its dependencies, it will get rebuilt when you flash.

Communicating

Run,

bazel run //tools:miniterm -- /dev/ttyACM0 --filter=debug

to communicate with the board. When you transmit a character, you should get the same character back!