| commit | ea4b4e47e151ee59cc25239b5735e97a4c11dfbe | [log] [tgz] |
|---|---|---|
| author | Ben <benlawson@pigweed.infra.roller.google.com> | Fri Oct 10 21:20:52 2025 -0700 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Oct 10 21:20:52 2025 -0700 |
| tree | a6c2850f2ff520ecfbb982caa03b24c3c94385b9 | |
| parent | c39113faa2c00e26e3cd064429aaf63a5fcb4c0e [diff] |
roll: pigweed pw_bluetooth_proxy: Fix undefined behavior in DeregisterChannelLocked Fix dereference of the channels_.end() iterator, which UBSan flagged as undefined behavior in a downstream project. This is already covered by tests like ChannelProxyTest.ChannelsStopOnProxyDestruction, but the UBSan failure is not triggered until member variables are added to L2capChannelManager that move the location of channels_ out of 16-byte alignment. The end() iterator is a list item base class without a L2capChannel subclass, so dereferencing it tries to downcast to a non-existent subclass. Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/331313 Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Original-Revision: 6b148032eba5cfc22d33a5a953401dbfc276578c Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed Rolled-Commits: d390baa10ed74e..6b148032eba5cf Roll-Count: 1 Roller-URL: https://cr-buildbucket.appspot.com/build/8701336086198395281 GitWatcher: ignore CQ-Do-Not-Cancel-Tryjobs: true Change-Id: Ia8c4e1206dbcc9472c3d8ca1a33512c1ee6b9716 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/quickstart/bazel/+/331412 Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
This repository contains a minimal example of a Bazel-based Pigweed project. It is a LED-blinking service (featuring RPC control!) for the Raspberry Pi Pico. It can also be run on any computer using the included simulator.
git clone https://pigweed.googlesource.com/pigweed/quickstart/bazel pw_bazel_quickstart cd pw_bazel_quickstart
The only dependency that must be installed is Bazelisk.
Bazelisk is a launcher for the Bazel build system that allows for easy management of multiple Bazel versions.
Instructions for installing Bazelisk can be found here.
To run the simulator, type: bazelisk run //apps/blinky:simulator_blinky Then, in a new console, connect to the simulator using: bazelisk run //apps/blinky:simulator_console
To start, connect a Raspberry Pi Pico, Pico 2, or debug probe via USB.
To run on the Raspberry Pi Pico, type: bazelisk run //apps/blinky:flash_rp2040 Then, in a new console, connect to the device using: bazelisk run //apps/blinky:rp2040_console
Once connected with a console, RPCs can be sent to control the LED. Try running:
device.set_led(True) device.set_led(False) device.toggle_led() device.blink(blink_count=3)
bazelisk test //... will run the unit tests defined in this project, such as the ones in modules/blinky/blinky_test.cc.
bazelisk run @pigweed//targets/rp2040/py:unit_test_server in one console followed by bazelisk test //... --config=rp2040 will also allow running the unit tests on-device.
Try poking around the codebase for inspiration about how Pigweed projects can be organized. Most of the relevant code in this quickstart (including RPC definitions) is inside modules/blinky, with some client-side Python code in tools/console.py.