| commit | ee783a287111d769bba4b160af08a44afb606edb | [log] [tgz] |
|---|---|---|
| author | Austin Foxley <afoxley@pigweed.infra.roller.google.com> | Wed Oct 09 18:45:11 2024 +0000 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Oct 09 18:45:11 2024 +0000 |
| tree | ce19fee3b106428847a062c1ddc93f1cdb8eda4e | |
| parent | 25dd7325e3a25dcd19027fac8c78ff7dd5f3f145 [diff] |
roll: pigweed pw_protobuf: Support directly specifying options file locations Replace the existing import-prefix arg to pwpb protoc plugin with an option to directly specify the location of any .options files to load from. The import-prefix option was added to try and find options files whose proto paths had been modified via the import_prefix bazel attr. This worked fine as long as you were careful to place your options files in a place where the existing search paths could find them. We've found it's easy to break this arrangement if the real path of the .options file isn't prefixed by the virtual import path of the proto. This could be fixed by a further complicated dance of constructing search paths that the plugin will then further mangle to check if the options file exists. This CL instead directly specifies the location of any options files for the pwpb plugin, while leaving in place the existing search path logic required for nanopb options files. Original-Bug: https://pwbug.dev/253068333 Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/240833 Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Original-Revision: 6efc99b3ee854dd54a0b1465d9014c54e01b21b9 Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed Rolled-Commits: 4321a46654fae2..6efc99b3ee854d Roller-URL: https://ci.chromium.org/b/8734531448713804129 GitWatcher: ignore CQ-Do-Not-Cancel-Tryjobs: true Change-Id: Ibd864566235418f6ed8c0a0a60cb7bae311c0af0 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/showcase/sense/+/241115 Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com> Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
git clone https://pigweed.googlesource.com/pigweed/showcase/sense
Welcome to Pigweed Sense, a tour of key Pigweed components experienced through an imagined air quality product.
Please visit Sense: An interactive tour through Pigweed to get started.