commit 080f38c1a0dfd6ccc58b3bdffb8d33b49c8b1c0f
author Austin Foxley <afoxley@pigweed.infra.roller.google.com> Fri Oct 04 21:06:44 2024 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Oct 04 21:06:44 2024 +0000
tree dd02176886f17d935938341432901791ace24f3f
parent a45532723c083c9bf3360a1b74fe4b4548cac5a5

roll: pigweed pw_rpc: Fix Call not getting reset on default constructor assignment

When trying to reinitialize an already used Call object to default,
the move constructor runs but ends up exiting early before actually
resetting the call internal state due to this conditional:

  if (!other.active_locked()) {
    return;  // Nothing else to do; this call is already closed.
  }

A default Call has state_ initialized to 0, so active_locked()
returns false so none of the assignments happen on `this`.

We fix this by letting the bulk of the move assignments happen
regardless of active state, except for those parts that apply
specifically to active calls.

Original-Bug: 371211198
Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/239718
Original-Revision: 05e93dadc080e45d624d92b80879297cfade417c

Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed
Rolled-Commits: 2e91930eff5ffa..05e93dadc080e4
Roller-URL: https://ci.chromium.org/b/8734974974735441601
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: Iac6358f96773f041ec9e97c9bf1953770b8d1516
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/showcase/sense/+/240140
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>