roll: pigweed, pw_toolchain: pw_kvs: Move inline variable definition to .cc file
no_inline_ is defined as an inline variable. pw::Vector has a
non-default constructor, which causes Clang to use the SHF_GNU_RETAIN
section flag (at least when compiling for RP2). Since SHF_GNU_RETAIN is
a GNU extension, Clang sets the ELF's EI_OSABI field to ELFOSABI_GNU,
instead of the default ELFOSABI_NONE.
Picotool only accepts ELFs with an EI_OSABI of ELFOSABI_NONE, even if
the binary is actually compatible. To avoid this issue, do not use an
inline variable.
Original-Bug: b/357162923
Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/228514
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
https://pigweed.googlesource.com/pigweed/pigweed
pigweed, pw_toolchain Rolled-Commits: e011157a9cb05a0..7ef5e1f643b8439
Roller-URL: https://ci.chromium.org/b/8739682616467026673
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I727096593312cc2990dc7ae0d2cb307a3fef6332
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/showcase/sense/+/229327
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
diff --git a/MODULE.bazel b/MODULE.bazel
index 03398f3..78d2f11 100644
--- a/MODULE.bazel
+++ b/MODULE.bazel
@@ -48,8 +48,8 @@
module_name = "pigweed",
# ROLL: Warning: this entry is automatically updated.
# ROLL: Last updated 2024-08-13.
- # ROLL: By https://cr-buildbucket.appspot.com/build/8739684868653404273.
- commit = "e011157a9cb05a002ce43ecf67e563469ca27ac4",
+ # ROLL: By https://cr-buildbucket.appspot.com/build/8739682616467026673.
+ commit = "7ef5e1f643b8439a1a1e9737827933c075d00f68",
remote = "https://pigweed.googlesource.com/pigweed/pigweed",
)
@@ -57,8 +57,8 @@
module_name = "pw_toolchain",
# ROLL: Warning: this entry is automatically updated.
# ROLL: Last updated 2024-08-13.
- # ROLL: By https://cr-buildbucket.appspot.com/build/8739684868653404273.
- commit = "e011157a9cb05a002ce43ecf67e563469ca27ac4",
+ # ROLL: By https://cr-buildbucket.appspot.com/build/8739682616467026673.
+ commit = "7ef5e1f643b8439a1a1e9737827933c075d00f68",
remote = "https://pigweed.googlesource.com/pigweed/pigweed",
strip_prefix = "pw_toolchain_bazel",
)
