commit | 6b696637e3f5fdf5de31f558a193d4bec3d20d7b | [log] [tgz] |
---|---|---|
author | Wyatt Hepler <hepler@pigweed.infra.roller.google.com> | Fri Aug 16 16:40:52 2024 +0000 |
committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Aug 16 16:40:52 2024 +0000 |
tree | 2d0848ac90e90457039252d46baa8dd80f71be66 | |
parent | 62f103730f790768fc9ceb44777a9bdde03c9c13 [diff] |
roll: pigweed, pw_toolchain: pw_kvs: Remove unnecessary Key alias and test pw_kvs originally used std::string_view for keys. A downstream project wanted to use pw_kvs in C++14, so implemented pw::kvs::Key, a custom version of std::string_view in e64daf43. That team later migrated to a newer C++ standard, and Pigweed dropped C++14 support, so the Key implementation was converted to an alias. The Key alias is unused outside pw_kvs, so remove it. Also remove code that hints at C++14 support, since it is not supported in Pigweed. This is potentially a BREAKING CHANGE! References to pw::kvs::Key must be replaced with std::string_view. Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/229976 https://pigweed.googlesource.com/pigweed/pigweed pigweed, pw_toolchain Rolled-Commits: 5e9e39285969463..9b242113ab06e86 Roller-URL: https://ci.chromium.org/b/8739431030426514801 GitWatcher: ignore CQ-Do-Not-Cancel-Tryjobs: true Change-Id: I031aad199d18c8bab5b35bfbfdcde79e188f790f Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/showcase/sense/+/230142 Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com> Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com> Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
git clone https://pigweed.googlesource.com/pigweed/showcase/sense
Welcome to Pigweed Sense, a tour of key Pigweed components experienced through an imagined air quality product.
Please visit Sense: An interactive tour through Pigweed to get started.