| commit | ca07100c4fb16af3227a1dc92f15c7f50687bca4 | [log] [tgz] |
|---|---|---|
| author | Anthony DiGirolamo <tonymd@pigweed.infra.roller.google.com> | Tue Oct 08 21:41:45 2024 +0000 |
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Oct 08 21:41:45 2024 +0000 |
| tree | 1e56a81e8a030cf25f4e6c8c60244eeeab930d1c | |
| parent | f0469c58decac12323732bd609d508ad3867ce05 [diff] |
roll: pigweed pw_console: Fix progress bar division by zero
In some cases it is possible to render a pw_console progress bar while
the elapsed time is still zero. This causes a divide by zero error:
File
".../python-venv/lib/site-packages/prompt_toolkit/shortcuts/progress_bar/formatters.py",
line 325, in <listcomp>
len(f"{c.items_completed / c.time_elapsed.total_seconds():.2f}")
Exception float division by zero
The background on why this is an issue is that pw_console removes the
required context manager of prompt_toolkits progress bar
implementation:
https://github.com/prompt-toolkit/python-prompt-toolkit/blob/master/src/prompt_toolkit/shortcuts/progress_bar/base.py#L6
So new runtime errors are possible depending on how the pw_console
start_progress and update_progress functions are
used. https://cs.opensource.google/pigweed/pigweed/+/main:pw_console/py/pw_console/progress_bar/__init__.py
Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/233033
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Original-Revision: 8bd77aba07ab3dce5220b23994cd3ecfbcefda10
Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed
Rolled-Commits: 28288477f008c6..8bd77aba07ab3d
Roller-URL: https://ci.chromium.org/b/8734611513227134881
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I538c62855e6dc2a226fa80630c8a66515b194191
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/showcase/sense/+/240709
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
git clone https://pigweed.googlesource.com/pigweed/showcase/sense
Welcome to Pigweed Sense, a tour of key Pigweed components experienced through an imagined air quality product.
Please visit Sense: An interactive tour through Pigweed to get started.