commit f1a3ee311da022d770ffec4cc2011a6daae36381
author Wyatt Hepler <hepler@pigweed.infra.roller.google.com> Tue Nov 12 08:34:14 2024 +0000
committer CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Nov 12 08:34:14 2024 +0000
tree bd2b682381ab3d90454d1142d2a9483669a3abe2
parent 267c3967fff35bbaadf40c7ff013c20ff99f08f8

roll: pigweed pw_channel: Rework inheritance to avoid SiblingCast

Change pw_channel to a new inheritance pattern that places AnyChannel in
the middle of the hierarchy. The various Channel API classes are private
empty bases of AnyChannel. This ensures conversions between compatible
Channel variants are valid, since all channel implementations have all
channel variants as bases. Channel implementations extend a ChannelImpl
with properties specified in template parameters, and unsupported
functions are automatically disabled.

This change also refactors and simplifies the channel.h header.
Properties and code for checking them are moved to a properties.h
header. Also, the macros to generate ChannelImpl specializations are
greatly simplified.

Original-Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/247732
Original-Revision: 0422de1761e52ad5d1fad821880025fc27facf1c

Rolled-Repo: https://pigweed.googlesource.com/pigweed/pigweed
Rolled-Commits: c521eeca9d3860..0422de1761e52a
Roll-Count: 1
Roller-URL: https://cr-buildbucket.appspot.com/build/8731489077423146209
GitWatcher: ignore
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I3663a9e8c88c8be9c395bf596ba7c8940317f7aa
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/showcase/sense/+/248082
Commit-Queue: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Pigweed Roller <pigweed-roller@pigweed-service-accounts.iam.gserviceaccount.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>