Change how we fork so we don't fork while threads are present.

This fixes a couple things.

1) A flake that was common in debug builds where the
PerfettoCmdlineTest.*Trigger* tests would fail. The cause was we started
the service in a separate thread, which would hold a lock to fprintf
when we forked, but that would deadlock the forked child process and
then we would never progress until the test timed out.

2) In the PerfettoCmdlineTest.*Trigger* we exec twice causing a data
race when touching |stderr_| member variable of the test. This refactor
fixes this by making people explicitly provide the string the stderr
should be saved into.

Bug: 137770927
Change-Id: Ib75ab148de01115f6de05d914a2092dd7be6fe06
1 file changed
tree: cd68dbebc299a1d00f2e9e761332505a86d81ff7
  1. build_overrides/
  2. buildtools/
  3. debian/
  4. docs/
  5. gn/
  6. include/
  7. infra/
  8. protos/
  9. src/
  10. test/
  11. tools/
  12. ui/
  13. .clang-format
  14. .gitignore
  15. .gn
  16. .travis.yml
  17. Android.bp
  18. Android.bp.extras
  19. BUILD
  20. BUILD.extras
  21. BUILD.gn
  22. codereview.settings
  23. heapprofd.rc
  24. MODULE_LICENSE_APACHE2
  25. NOTICE
  26. OWNERS
  27. perfetto.rc
  28. PRESUBMIT.py
  29. README.chromium
  30. README.md
  31. TEST_MAPPING
README.md

Perfetto - Performance instrumentation and tracing

Perfetto is an open-source project for performance instrumentation and tracing of Linux/Android/Chrome platforms and user-space apps.

See www.perfetto.dev for docs.

Bugs

  • For bugs affecting Android or the tracing internals use the internal bug tracker (go/perfetto-bugs).
  • For bugs affecting Chrome use http://crbug.com, Component:Speed>Tracing label:Perfetto.